aljaz/lightning
1
0
Fork 0
mirror of https://github.com/aljazceru/lightning.git synced 2025-12-23 00:54:20 +01:00
Code Issues Packages Projects Releases Wiki Activity

gossipd: fix leak when we fail to dup fds.

Browse Source 
In this case, peer would stay around, but conn would be freed.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This commit is contained in:
Rusty Russell
2018-06-14 12:10:06 +09:30
committed by Christian Decker
parent f6ff89e596
commit e098578731
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
gossipd/gossip.c
View File

@@ -650,10 +650,6 @@ static struct io_plan *peer_connected(struct io_conn *conn, struct peer *peer)
= peer->daemon->rstate->broadcasts->next_index; = peer->daemon->rstate->broadcasts->next_index;
} }
/* This is a full peer now; we keep it around until master says
* it's dead. */
peer_finalized(peer);
/* We will not have anything queued, since we're not duplex. */ /* We will not have anything queued, since we're not duplex. */
msg = towire_gossip_peer_connected(peer, &peer->id, &peer->addr, msg = towire_gossip_peer_connected(peer, &peer->id, &peer->addr,
&peer->local->pcs.cs, &peer->local->pcs.cs,
@@ -661,6 +657,10 @@ static struct io_plan *peer_connected(struct io_conn *conn, struct peer *peer)
if (!send_peer_with_fds(peer, msg)) if (!send_peer_with_fds(peer, msg))
return io_close(conn); return io_close(conn);
/* This is a full peer now; we keep it around until master says
* it's dead. */
peer_finalized(peer);
/* Start the gossip flowing. */ /* Start the gossip flowing. */
wake_gossip_out(peer); wake_gossip_out(peer);