aljaz/lightning
1
0
Fork 0
mirror of https://github.com/aljazceru/lightning.git synced 2025-12-19 15:14:23 +01:00
Code Issues Packages Projects Releases Wiki Activity

lightningd: dump backtrace on crash or fatal().

Browse Source 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This commit is contained in:
Rusty Russell
2017-09-12 14:26:45 +09:30
committed by Christian Decker
parent dba27188b7
commit db19873ee4
3 changed files with 21 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lightningd/lightningd.c
View File

@@ -211,7 +211,7 @@ int main(int argc, char *argv[])
newdir = handle_opts(ld, argc, argv); newdir = handle_opts(ld, argc, argv);
/* Activate crash log now we're in the right place. */ /* Activate crash log now we're in the right place. */
crashlog_activate(ld->log); crashlog_activate(argv[0], ld->log);
/* Ignore SIGPIPE: we look at our write return values*/ /* Ignore SIGPIPE: we look at our write return values*/
signal(SIGPIPE, SIG_IGN); signal(SIGPIPE, SIG_IGN);

22
lightningd/log.c
View File

@@ -1,4 +1,5 @@
#include "log.h" #include "log.h"
#include <backtrace.h>
#include <ccan/array_size/array_size.h> #include <ccan/array_size/array_size.h>
#include <ccan/list/list.h> #include <ccan/list/list.h>
#include <ccan/opt/opt.h> #include <ccan/opt/opt.h>
@@ -17,6 +18,8 @@
#include <sys/types.h> #include <sys/types.h>
#include <unistd.h> #include <unistd.h>
static struct backtrace_state *backtrace_state;
struct log_entry { struct log_entry {
struct list_node list; struct list_node list;
struct timeabs time; struct timeabs time;
@@ -411,6 +414,15 @@ void opt_register_logging(struct log *log)
"log to file instead of stdout"); "log to file instead of stdout");
} }
static int log_backtrace(void *log, uintptr_t pc,
const char *filename, int lineno,
const char *function)
{
log_broken(log, "backtrace: %s:%u (%s) %p",
filename, lineno, function, (void *)pc);
return 0;
}
static struct log *crashlog; static struct log *crashlog;
/* FIXME: Dump peer logs! */ /* FIXME: Dump peer logs! */
@@ -419,8 +431,9 @@ static void log_crash(int sig)
const char *logfile = NULL; const char *logfile = NULL;
if (sig) { if (sig) {
/* FIXME: Backtrace! */
log_broken(crashlog, "FATAL SIGNAL %i RECEIVED", sig); log_broken(crashlog, "FATAL SIGNAL %i RECEIVED", sig);
backtrace_full(backtrace_state, 0, log_backtrace, NULL,
crashlog);
} }
if (crashlog->lr->print == log_default_print) { if (crashlog->lr->print == log_default_print) {
@@ -442,18 +455,21 @@ static void log_crash(int sig)
logfile = NULL; logfile = NULL;
} }
if (sig) if (sig) {
fprintf(stderr, "Fatal signal %u. ", sig); fprintf(stderr, "Fatal signal %u. ", sig);
backtrace_print(backtrace_state, 0, stderr);
}
if (logfile) if (logfile)
fprintf(stderr, "Log dumped in %s", logfile); fprintf(stderr, "Log dumped in %s", logfile);
fprintf(stderr, "\n"); fprintf(stderr, "\n");
} }
void crashlog_activate(struct log *log) void crashlog_activate(const char *argv0, struct log *log)
{ {
struct sigaction sa; struct sigaction sa;
crashlog = log; crashlog = log;
backtrace_state = backtrace_create_state(argv0, 0, NULL, NULL);
sa.sa_handler = log_crash; sa.sa_handler = log_crash;
sigemptyset(&sa.sa_mask); sigemptyset(&sa.sa_mask);
/* We want to fall through to default handler */ /* We want to fall through to default handler */

2
lightningd/log.h
View File

@@ -87,7 +87,7 @@ void log_each_line_(const struct log_book *lr,
void log_dump_to_file(int fd, const struct log_book *lr); void log_dump_to_file(int fd, const struct log_book *lr);
void opt_register_logging(struct log *log); void opt_register_logging(struct log *log);
void crashlog_activate(struct log *log); void crashlog_activate(const char *argv0, struct log *log);
/* Convenience parent for temporary allocations (eg. type_to_string) /* Convenience parent for temporary allocations (eg. type_to_string)
* during log calls; freed after every log_*() */ * during log calls; freed after every log_*() */