aljaz/lightning
1
0
Fork 0
mirror of https://github.com/aljazceru/lightning.git synced 2025-12-20 15:44:21 +01:00
Code Issues Packages Projects Releases Wiki Activity

pytest: Disable MPP sending for 4 tests

Browse Source 
These mostly deal with exact HTLC counts, and fixed number of attempts to
conclusion, so the randomization that MPP adds is not desirable.
This commit is contained in:
Christian Decker
2020-07-13 17:38:12 +02:00
parent 212a3c5ec5
commit dad23066dc
3 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
tests/test_closing.py
View File

@@ -732,6 +732,7 @@ def test_penalty_htlc_tx_fulfill(node_factory, bitcoind, chainparams):
may_reconnect=True, may_reconnect=True,
options={'dev-no-reconnect': None}) options={'dev-no-reconnect': None})
l2 = node_factory.get_node(options={'plugin': coin_mvt_plugin, l2 = node_factory.get_node(options={'plugin': coin_mvt_plugin,
'disable-mpp': None,
'dev-no-reconnect': None}, 'dev-no-reconnect': None},
may_reconnect=True, may_reconnect=True,
allow_broken_log=True) allow_broken_log=True)
@@ -910,11 +911,9 @@ def test_penalty_htlc_tx_timeout(node_factory, bitcoind, chainparams):
# push some money so that 1 + 4 can both send htlcs # push some money so that 1 + 4 can both send htlcs
inv = l1.rpc.invoice(10**9 // 2, '1', 'balancer') inv = l1.rpc.invoice(10**9 // 2, '1', 'balancer')
l2.rpc.pay(inv['bolt11']) l2.rpc.pay(inv['bolt11'])
l2.rpc.waitsendpay(inv['payment_hash'])
inv = l4.rpc.invoice(10**9 // 2, '1', 'balancer') inv = l4.rpc.invoice(10**9 // 2, '1', 'balancer')
l2.rpc.pay(inv['bolt11']) l2.rpc.pay(inv['bolt11'])
l2.rpc.waitsendpay(inv['payment_hash'])
# now we send two 'sticky' htlcs, l1->l5 + l4->l1 # now we send two 'sticky' htlcs, l1->l5 + l4->l1
amt = 10**8 // 2 amt = 10**8 // 2

2
tests/test_connection.py
View File

@@ -1963,7 +1963,7 @@ def test_fulfill_incoming_first(node_factory, bitcoind):
# We manually reconnect l2 & l3, after 100 blocks; hence allowing manual # We manually reconnect l2 & l3, after 100 blocks; hence allowing manual
# reconnect, but disabling auto connect, and massive cltv so 2/3 doesn't # reconnect, but disabling auto connect, and massive cltv so 2/3 doesn't
# time out. # time out.
l1, l2, l3 = node_factory.line_graph(3, opts=[{}, l1, l2, l3 = node_factory.line_graph(3, opts=[{'disable-mpp': None},
{'may_reconnect': True, {'may_reconnect': True,
'dev-no-reconnect': None}, 'dev-no-reconnect': None},
{'may_reconnect': True, {'may_reconnect': True,

8
tests/test_pay.py
View File

@@ -138,7 +138,11 @@ def test_pay_exclude_node(node_factory, bitcoind):
""" """
# FIXME: Remove our reliance on HTLCs failing on startup and the need for # FIXME: Remove our reliance on HTLCs failing on startup and the need for
# this plugin # this plugin
opts = [{}, {'plugin': os.path.join(os.getcwd(), 'tests/plugins/fail_htlcs.py')}, {}] opts = [
{'disable-mpp': None},
{'plugin': os.path.join(os.getcwd(), 'tests/plugins/fail_htlcs.py')},
{}
]
l1, l2, l3 = node_factory.line_graph(3, opts=opts, wait_for_announce=True) l1, l2, l3 = node_factory.line_graph(3, opts=opts, wait_for_announce=True)
amount = 10**8 amount = 10**8
@@ -1615,7 +1619,7 @@ def test_pay_retry(node_factory, bitcoind, executor, chainparams):
# We connect every node to l5; in a line and individually. # We connect every node to l5; in a line and individually.
# Keep fixed fees so we can easily calculate exhaustion # Keep fixed fees so we can easily calculate exhaustion
l1, l2, l3, l4, l5 = node_factory.line_graph(5, fundchannel=False, l1, l2, l3, l4, l5 = node_factory.line_graph(5, fundchannel=False,
opts={'feerates': (7500, 7500, 7500, 7500)}) opts={'feerates': (7500, 7500, 7500, 7500), 'disable-mpp': None})
# scid12 # scid12
l1.fund_channel(l2, 10**6, wait_for_active=False) l1.fund_channel(l2, 10**6, wait_for_active=False)