From d8fc5332c3cb3bccf29a9eba8060483ec52e094d Mon Sep 17 00:00:00 2001 From: Rusty Russell Date: Fri, 6 Dec 2019 14:24:41 +1030 Subject: [PATCH] pytest: test rpc_command hook when it handles command to stop itself. Signed-off-by: Rusty Russell --- tests/plugins/rpc_command.py | 2 +- tests/test_plugin.py | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/tests/plugins/rpc_command.py b/tests/plugins/rpc_command.py index 4a47e6235..506e7cb4b 100755 --- a/tests/plugins/rpc_command.py +++ b/tests/plugins/rpc_command.py @@ -4,7 +4,7 @@ This plugin is used to test the `rpc_command` hook. """ from lightning import Plugin -plugin = Plugin(dynamic=False) +plugin = Plugin() @plugin.hook("rpc_command") diff --git a/tests/test_plugin.py b/tests/test_plugin.py index caa325ea9..4da0e4baa 100644 --- a/tests/test_plugin.py +++ b/tests/test_plugin.py @@ -761,6 +761,7 @@ def test_sendpay_notifications(node_factory, bitcoind): assert results['sendpay_failure'][0] == err.value.error +@pytest.mark.xfail(strict=True) def test_rpc_command_hook(node_factory): """Test the `sensitive_command` hook""" plugin = os.path.join(os.getcwd(), "tests/plugins/rpc_command.py") @@ -778,3 +779,6 @@ def test_rpc_command_hook(node_factory): # The plugin sends a custom response to "listfunds" funds = l1.rpc.listfunds() assert funds[0] == "Custom result" + + # Test command which removes plugin itself! + l1.rpc.plugin_stop('rpc_command.py')