aljaz/lightning
1
0
Fork 0
mirror of https://github.com/aljazceru/lightning.git synced 2025-12-19 15:14:23 +01:00
Code Issues Packages Projects Releases Wiki Activity

signmessage: improve the UX of the rpc command when zbase is not a valid one

Browse Source 
Changelog-Fixed: signmessage: improve the UX of the rpc command when zbase is not a valid one

Stacktrace generated with a bad `zbase`

```
lightningd: lightningd/signmessage.c:59: from_zbase32: Assertion `len == tal_bytelen(u8arr)' failed
lightningd: FATAL SIGNAL 6 (version v0.11.1)
0x55b9b1b4e617 send_backtrace
[...]
```

Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
This commit is contained in:
Vincenzo Palazzo
2022-06-17 20:48:32 +01:00
committed by Rusty Russell
parent 49c6459148
commit d4bc4f6460
2 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lightningd/signmessage.c
View File

@@ -56,8 +56,7 @@ static const u8 *from_zbase32(const tal_t *ctx, const char *msg)
if (!bech32_convert_bits(u8arr, &len, 8, if (!bech32_convert_bits(u8arr, &len, 8,
u5arr, tal_bytelen(u5arr), 5, false)) u5arr, tal_bytelen(u5arr), 5, false))
return tal_free(u8arr); return tal_free(u8arr);
assert(len == tal_bytelen(u8arr)); return len == tal_bytelen(u8arr) ? u8arr : tal_free(u8arr);
return u8arr;
} }
static struct command_result *json_signmessage(struct command *cmd, static struct command_result *json_signmessage(struct command *cmd,
@@ -235,4 +234,3 @@ static const struct json_command json_checkmessage_cmd = {
"Verify a digital signature {zbase} of {message} signed with {pubkey}", "Verify a digital signature {zbase} of {message} signed with {pubkey}",
}; };
AUTODATA(json_command, &json_checkmessage_cmd); AUTODATA(json_command, &json_checkmessage_cmd);

3
tests/test_misc.py
View File

@@ -1866,6 +1866,9 @@ def test_signmessage(node_factory):
checknokey = l2.rpc.checkmessage(message="message for you", zbase=zm) checknokey = l2.rpc.checkmessage(message="message for you", zbase=zm)
assert checknokey['pubkey'] == l1.info['id'] assert checknokey['pubkey'] == l1.info['id']
assert checknokey['verified'] assert checknokey['verified']
# check that checkmassage used with a wrong zbase format throws an RPC exception
with pytest.raises(RpcError, match="zbase is not valid zbase32"):
l2.rpc.checkmessage(message="wrong zbase format", zbase="wrong zbase format")
def test_include(node_factory): def test_include(node_factory):