aljaz/lightning
1
0
Fork 0
mirror of https://github.com/aljazceru/lightning.git synced 2025-12-19 23:24:27 +01:00
Code Issues Packages Projects Releases Wiki Activity

gossipd: add a BOLT#7 comment when wrong chain_hash in 'query_channel_range'

Browse Source 
And correct some typos
This commit is contained in:
darosior
2019-10-01 21:15:06 +02:00
committed by neil saitug
parent d59015d4ca
commit d3c8225968
1 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
gossipd/queries.c
View File

@@ -334,7 +334,7 @@ static void reply_channel_range(struct peer *peer,
* knows in blocks `first_blocknum` to `first_blocknum` plus * knows in blocks `first_blocknum` to `first_blocknum` plus
* `number_of_blocks` minus one. * `number_of_blocks` minus one.
* - MUST limit `number_of_blocks` to the maximum number of blocks * - MUST limit `number_of_blocks` to the maximum number of blocks
* whose results could fit in `encoded_short_ids` * whose results could fit in `encoded_short_ids`
* - if does not maintain up-to-date channel information for * - if does not maintain up-to-date channel information for
* `chain_hash`: * `chain_hash`:
* - MUST set `complete` to 0. * - MUST set `complete` to 0.
@@ -556,7 +556,7 @@ wont_fit:
tail_blocks, query_option_flags); tail_blocks, query_option_flags);
} }
/*~ The peer can ask for all channels is a series of blocks. We reply with one /*~ The peer can ask for all channels in a series of blocks. We reply with one
* or more messages containing the short_channel_ids. */ * or more messages containing the short_channel_ids. */
const u8 *handle_query_channel_range(struct peer *peer, const u8 *msg) const u8 *handle_query_channel_range(struct peer *peer, const u8 *msg)
{ {
@@ -580,8 +580,13 @@ const u8 *handle_query_channel_range(struct peer *peer, const u8 *msg)
else else
query_option_flags = 0; query_option_flags = 0;
/* If they ask for the wrong chain, we give an empty response /* BOLT #7
* with the `complete` flag unset */ *
* The receiver of `query_channel_range`:
* ...
* - if does not maintain up-to-date channel information for `chain_hash`:
* - MUST set `complete` to 0.
*/
if (!bitcoin_blkid_eq(&peer->daemon->chain_hash, &chain_hash)) { if (!bitcoin_blkid_eq(&peer->daemon->chain_hash, &chain_hash)) {
status_debug("%s sent query_channel_range chainhash %s", status_debug("%s sent query_channel_range chainhash %s",
type_to_string(tmpctx, struct node_id, &peer->id), type_to_string(tmpctx, struct node_id, &peer->id),