libplugin: fix 'dynamic' field in getmanifest

As a separated commit because it was pre-existent (changelog + xfail test).

This also fix a logical problem in lightningd/plugin_control: we were
assuming a plugin started with 'plugin start' but which did not comport
a 'dynamic' entry in its manifest to be dynamic, though it should have
been treated as static.

Changelog-fixed: plugins: Dynamic C plugins can now be managed when lightningd is up
This commit is contained in:
darosior
2020-01-31 19:13:59 +01:00
committed by Rusty Russell
parent da476848d1
commit ceeb5503cc
4 changed files with 7 additions and 8 deletions

View File

@@ -791,7 +791,6 @@ def test_rpc_command_hook(node_factory):
l1.rpc.plugin_stop('rpc_command.py')
@pytest.mark.xfail(strict=True)
def test_libplugin(node_factory):
"""Sanity checks for plugins made with libplugin"""
plugin = os.path.join(os.getcwd(), "tests/plugins/test_libplugin")