aljaz/lightning
1
0
Fork 0
mirror of https://github.com/aljazceru/lightning.git synced 2025-12-19 23:24:27 +01:00
Code Issues Packages Projects Releases Wiki Activity

resolve() appears broken on Python 3.7+

Browse Source 
On my machine it should have produced:
/tmp/ltests-1p0v5z1j/.locks/lock-1631090663.1066182
but instead it produced:
/private/tmp/ltests-1p0v5z1j/.locks/lock-1631090663.105848

The mismatch resulted in a hang inside flock.

Path .resolve() seems to be causing problems for others as well. It appears the library was not meant to handle complex path situations and isn't maintained as such (see link reference).

Since we have already built a full path here anyway, the call to .resolve() appears redundant.

Tested on python 3.9.6 on my Mac OS X 11.4 (20F71), Xcode 12.5.1 (12E507)

Relevant discussion: https://discuss.python.org/t/pathlib-absolute-vs-resolve/2573
This commit is contained in:
Dustin Dettmer
2021-09-08 10:57:37 -07:00
committed by Christian Decker
parent a308fb17b2
commit cdb93eefec
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
contrib/pyln-testing/pyln/testing/utils.py
View File

@@ -1151,7 +1151,7 @@ def flock(directory: Path):
# So now we have a position in the lock, let's check if we are the # So now we have a position in the lock, let's check if we are the
# next one to go: # next one to go:
while True: while True:
files = sorted([f.resolve() for f in d.iterdir() if f.is_file()]) files = sorted([f for f in d.iterdir() if f.is_file()])
# We're queued, so it should at least have us. # We're queued, so it should at least have us.
assert len(files) >= 1 assert len(files) >= 1
if files[0] == fname: if files[0] == fname: