aljaz/lightning
1
0
Fork 0
mirror of https://github.com/aljazceru/lightning.git synced 2025-12-19 23:24:27 +01:00
Code Issues Packages Projects Releases Wiki Activity

channeld: restore ping command, but only for channeld.

Browse Source 
It's probably not worth fixing for the other daemons.

Changelog-Changed: JSON-RPC: `ping` now only works if we have a channel with the peer.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This commit is contained in:
Rusty Russell
2021-10-09 16:23:29 +10:30
committed by Christian Decker
parent be2622a4ff
commit c9b82bf1d2
9 changed files with 159 additions and 66 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
tests/test_misc.py
View File

@@ -253,9 +253,8 @@ def test_lightningd_still_loading(node_factory, bitcoind, executor):
l1.pay(l2, 1000)
@pytest.mark.skip(reason="FIXME: channeld needs to handle pings")
def test_ping(node_factory):
l1, l2 = node_factory.line_graph(2, fundchannel=False)
l1, l2 = node_factory.line_graph(2)
def ping_tests(l1, l2):
# 0-byte pong gives just type + length field.
@@ -284,14 +283,6 @@ def test_ping(node_factory):
with pytest.raises(RpcError, match=r'oversize ping'):
l1.rpc.ping(l2.info['id'], 65530, 1)
# Test gossip pinging.
ping_tests(l1, l2)
if DEVELOPER:
l1.daemon.wait_for_log(r'Got pong 1000 bytes \({}\.\.\.\)'
.format(l2.info['version']), timeout=1)
l1.fundchannel(l2, 10**5)
# channeld pinging
ping_tests(l1, l2)
if DEVELOPER: