aljaz/lightning
1
0
Fork 0
mirror of https://github.com/aljazceru/lightning.git synced 2025-12-20 23:54:22 +01:00
Code Issues Packages Projects Releases Wiki Activity

ld: Do not blindly add rebroadcasts to outgoing_tx set

Browse Source 
The list of outgoing transactions was growing with every
rebroadcast. Now we just check whether it is already in the list and
don't add it anymore

Changelog-Fixed: ld: Reduce identification of own transactions to not slow down over time, reducing block processing time

Suggested-by: Matt Whitlock <@whitslack>
This commit is contained in:
Christian Decker
2022-11-15 14:19:48 +01:00
parent f2291c44d6
commit c7ff3c4288
1 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
lightningd/chaintopology.c
View File

@@ -208,6 +208,13 @@ static void broadcast_done(struct bitcoind *bitcoind,
if (otx->failed_or_success) { if (otx->failed_or_success) {
otx->failed_or_success(otx->channel, success, msg); otx->failed_or_success(otx->channel, success, msg);
tal_free(otx); tal_free(otx);
} else if (we_broadcast(bitcoind->ld->topology, &otx->txid)) {
log_debug(
bitcoind->ld->topology->log,
"Not adding %s to list of outgoing transactions, already "
"present",
type_to_string(tmpctx, struct bitcoin_txid, &otx->txid));
tal_free(otx);
} else { } else {
/* For continual rebroadcasting, until channel freed. */ /* For continual rebroadcasting, until channel freed. */
tal_steal(otx->channel, otx); tal_steal(otx->channel, otx);