pytest: Remove tests that rely on presplit behavior

These tests make assumptions about the presplitter behavior which
we'll remove in the next commit. We remove them here so we don't cause
temporary breaks in the git history.
This commit is contained in:
Christian Decker
2023-07-14 12:52:15 +02:00
committed by Rusty Russell
parent 55d6a13ffc
commit c3a983375c
2 changed files with 0 additions and 169 deletions

View File

@@ -2133,43 +2133,6 @@ def test_coin_movement_notices(node_factory, bitcoind, chainparams):
check_coin_moves(l2, chanid_3, l2_l3_mvts, chainparams)
def test_3847_repro(node_factory, bitcoind):
"""Reproduces the issue in #3847: duplicate response from plugin
l2 holds on to HTLCs until the deadline expires. Then we allow them
through and either should terminate the payment attempt, and the second
would return a redundant result.
"""
l1, l2, l3 = node_factory.line_graph(3, opts=[
{},
{},
{
'plugin': os.path.join(os.getcwd(), 'tests/plugins/hold_htlcs.py'),
'hold-time': 11,
'hold-result': 'fail',
},
], wait_for_announce=True)
wait_for(lambda: len(l1.rpc.listchannels()['channels']) == 4)
# Amount sufficient to trigger the presplit modifier
amt = 20 * 1000 * 1000
i1 = l3.rpc.invoice(
amount_msat=amt, label="direct", description="desc"
)['bolt11']
with pytest.raises(RpcError):
l1.rpc.pay(i1, retry_for=10)
# We wait for at least two parts, and the bug would cause the `pay` plugin
# to crash
l1.daemon.wait_for_logs([r'Payment deadline expired, not retrying'] * 2)
# This call to paystatus would fail if the pay plugin crashed (it's
# provided by the plugin)
l1.rpc.paystatus(i1)
def test_important_plugin(node_factory):
# Cache it here.
pluginsdir = os.path.join(os.path.dirname(__file__), "plugins")