From bc4a099bffa21de75edd12d9c4011d6e140db8fa Mon Sep 17 00:00:00 2001
From: practicalswift <practicalswift@users.noreply.github.com>
Date: Tue, 3 Apr 2018 18:42:09 +0200
Subject: [PATCH] Add shell script linting: Check for shellcheck warnings in
 shell scripts

---
 Makefile                        | 5 ++++-
 contrib/Dockerfile.builder      | 1 +
 contrib/Dockerfile.builder.i386 | 1 +
 3 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index f68ca47b9..9d7580475 100644
--- a/Makefile
+++ b/Makefile
@@ -263,7 +263,10 @@ check-includes:
 check-cppcheck: .cppcheck-suppress
 	@trap 'rm -f .cppcheck-suppress' 0; git ls-files -- "*.c" "*.h" | grep -vE '^ccan/' | xargs cppcheck -q --language=c --std=c11 --error-exitcode=1 --suppressions-list=.cppcheck-suppress
 
-check-source: check-makefile check-source-bolt check-whitespace check-markdown check-spelling check-python check-includes check-cppcheck
+check-shellcheck:
+	git ls-files -- "*.sh" | xargs shellcheck
+
+check-source: check-makefile check-source-bolt check-whitespace check-markdown check-spelling check-python check-includes check-cppcheck check-shellcheck
 
 full-check: check check-source
 
diff --git a/contrib/Dockerfile.builder b/contrib/Dockerfile.builder
index 49c368be1..eca431235 100644
--- a/contrib/Dockerfile.builder
+++ b/contrib/Dockerfile.builder
@@ -11,6 +11,7 @@ RUN apt-get -qq update && \
 	automake \
 	clang \
 	cppcheck \
+	shellcheck \
 	eatmydata \
 	software-properties-common \
 	build-essential \
diff --git a/contrib/Dockerfile.builder.i386 b/contrib/Dockerfile.builder.i386
index f2ca00bdb..6c5a84eb7 100644
--- a/contrib/Dockerfile.builder.i386
+++ b/contrib/Dockerfile.builder.i386
@@ -11,6 +11,7 @@ RUN apt-get -qq update && \
 	automake \
 	clang \
 	cppcheck \
+	shellcheck \
 	eatmydata \
 	software-properties-common \
 	build-essential \