From bb0286bb8234572d9f15a88131d0c24c77cbb24f Mon Sep 17 00:00:00 2001 From: Adi Shankara <85787690+adi-shankara@users.noreply.github.com> Date: Tue, 1 Aug 2023 13:19:29 +0530 Subject: [PATCH] fix workflow file and test changes (#6476) --- .github/workflows/rdme-docs-sync.yml | 9 +++++---- doc/beginners-guide/beginners-guide.md | 10 +--------- 2 files changed, 6 insertions(+), 13 deletions(-) diff --git a/.github/workflows/rdme-docs-sync.yml b/.github/workflows/rdme-docs-sync.yml index aae797dbb..eb848a577 100644 --- a/.github/workflows/rdme-docs-sync.yml +++ b/.github/workflows/rdme-docs-sync.yml @@ -1,15 +1,16 @@ name: ReadMe Sync on: - pull_request: + pull_request_target: types: - closed + branches: + - 'master' paths: - - 'doc/*' + - 'doc/' jobs: - if_merged: - if: github.event.pull_request.merged == true + rdme-docs: runs-on: ubuntu-latest steps: - name: Check out repo 📚 diff --git a/doc/beginners-guide/beginners-guide.md b/doc/beginners-guide/beginners-guide.md index 7770beb76..e36260583 100644 --- a/doc/beginners-guide/beginners-guide.md +++ b/doc/beginners-guide/beginners-guide.md @@ -16,16 +16,12 @@ If you want to experiment with `lightningd`, there's a script to set up a `bitco . contrib/startup_regtest.sh ``` - - Note that your local nodeset will be much faster/more responsive if you've configured your node to expose the developer options, e.g. ```bash ./configure --enable-developer ``` - - #### Mainnet Option To test with real bitcoin, you will need to have a local `bitcoind` node running: @@ -34,8 +30,6 @@ To test with real bitcoin, you will need to have a local `bitcoind` node runnin bitcoind -daemon ``` - - Wait until `bitcoind` has synchronized with the network. Make sure that you do not have `walletbroadcast=0` in your `~/.bitcoin/bitcoin.conf`, or you may run into trouble. @@ -47,8 +41,6 @@ You can start `lightningd` with the following command: lightningd --network=bitcoin --log-level=debug ``` - - This creates a `.lightning/` subdirectory in your home directory: see `man -l doc/lightningd.8` (or [???](???)) for more runtime options. ## Using The JSON-RPC Interface @@ -73,4 +65,4 @@ Once you've started for the first time, there's a script called `contrib/bootstr There are also numerous plugins available for Core Lightning which add capabilities: see the [Plugins](doc:plugins) guide, and check out the plugin collection at: , including [helpme](https://github.com/lightningd/plugins/tree/master/helpme) which guides you through setting up your first channels and customising your node. -For a less reckless experience, you can encrypt the HD wallet seed: see [HD wallet encryption](doc:securing-keys). \ No newline at end of file +For a less reckless experience, you can encrypt the HD wallet seed: see [HD wallet encryption](doc:securing-keys).