From ba36dfeba32b2b1ce5a9d2c0485bc5bb2daaca45 Mon Sep 17 00:00:00 2001 From: Michael Schmoock Date: Thu, 13 Feb 2020 12:32:26 +0100 Subject: [PATCH] doc: all requirements.txt are needed for testing the tests are not possible only by having tests/requirements.txt . Running the whole testsuite also runs contrib/pyln-proto/tests/test_invoice.py which needs requiremnets of pyln-proto and so on. Also requirement coincurve requires libsecp256k1-dev headers. As most developers need all requiremtents and we should tell them. --- doc/HACKING.md | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/doc/HACKING.md b/doc/HACKING.md index d02ba31a5..92569a5c8 100644 --- a/doc/HACKING.md +++ b/doc/HACKING.md @@ -160,8 +160,14 @@ Testing Install `valgrind` and the python dependencies for best results: ``` -sudo apt install valgrind cppcheck shellcheck -pip3 install -r tests/requirements.txt +sudo apt install valgrind cppcheck shellcheck libsecp256k1-dev +pip3 install --user \ + -r requirements.txt \ + -r contrib/pyln-client/requirements.txt \ + -r contrib/pyln-proto/requirements.txt \ + -r contrib/pyln-testing/requirements.txt \ + -r tests/requirements.txt \ + -r doc/requirements.txt ``` Re-run `configure` for the python dependencies