aljaz/lightning
1
0
Fork 0
mirror of https://github.com/aljazceru/lightning.git synced 2025-12-19 23:24:27 +01:00
Code Issues Packages Projects Releases Wiki Activity

channeld: don't close connection on invalid badonion code (LND bug?)

Browse Source 
```
channeld WARNING: Bad update_fail_malformed_htlc failure code 4103
```

Warren Togami reports this happening with Bitrefill on every reconnect,
so it's clearly something LND does.

(4103 is TEMPORARY_CHANNEL_FAILURE, which does not belong in update_fail_malformed_htlc).

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Changelog-Changed: Protocol: We allow update_fail_malformed_htlc with invalid error codes (LND?)
This commit is contained in:
Rusty Russell
2023-07-22 20:14:17 +09:30
parent a6ade2e071
commit b6f2eb949a
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
channeld/channeld.c
View File

@@ -1965,9 +1965,11 @@ static void handle_peer_fail_malformed_htlc(struct peer *peer, const u8 *msg)
* `error` and fail the channel. * `error` and fail the channel.
*/ */
if (!(failure_code & BADONION)) { if (!(failure_code & BADONION)) {
peer_failed_warn(peer->pps, &peer->channel_id, /* But LND (at least, Bitrefill to Blockstream Store) sends this? */
"Bad update_fail_malformed_htlc failure code %u", status_unusual("Bad update_fail_malformed_htlc failure code %u",
failure_code); failure_code);
/* We require this internally. */
failure_code |= BADONION;
} }
e = channel_fail_htlc(peer->channel, LOCAL, id, &htlc); e = channel_fail_htlc(peer->channel, LOCAL, id, &htlc);