From af502eb625b51a4b8ced54722fa66f79d29ab45d Mon Sep 17 00:00:00 2001
From: Michael Schmoock <michael@schmoock.net>
Date: Thu, 29 Dec 2022 14:17:09 +0100
Subject: [PATCH] pytest: adds test for msat to int comparison

Changelog-None
---
 .../pyln-client/tests/test_millisatoshi.py    | 39 +++++++++++++++++++
 1 file changed, 39 insertions(+)

diff --git a/contrib/pyln-client/tests/test_millisatoshi.py b/contrib/pyln-client/tests/test_millisatoshi.py
index f8f877ff0..b60c48089 100644
--- a/contrib/pyln-client/tests/test_millisatoshi.py
+++ b/contrib/pyln-client/tests/test_millisatoshi.py
@@ -1,6 +1,45 @@
+import pytest
 from pyln.client import Millisatoshi
 
 
 def test_sum_radd():
     result = sum([Millisatoshi(1), Millisatoshi(2), Millisatoshi(3)])
     assert int(result) == 6
+
+
+def test_compare_int():
+    # Test that we can compare msat to int numbers
+    assert Millisatoshi(10) == 10
+    assert Millisatoshi(10) > 9
+    assert Millisatoshi(10) >= 9
+    assert Millisatoshi(10) < 11
+    assert Millisatoshi(10) <= 11
+
+    # Same as above but check that the order doesn't matter
+    assert 10 == Millisatoshi(10)
+    assert 9 < Millisatoshi(10)
+    assert 9 <= Millisatoshi(10)
+    assert 11 > Millisatoshi(10)
+    assert 11 >= Millisatoshi(10)
+
+    # Test that we can't accidentally compare msat to float
+    assert Millisatoshi(10) != 10.0
+    with pytest.raises(AttributeError):
+        assert Millisatoshi(10) > 9.0
+    with pytest.raises(AttributeError):
+        assert Millisatoshi(10) >= 9.0
+    with pytest.raises(AttributeError):
+        assert Millisatoshi(10) < 11.0
+    with pytest.raises(AttributeError):
+        assert Millisatoshi(10) <= 11.0
+
+    # ... and again that order does not matter
+    assert 10.0 != Millisatoshi(10)
+    with pytest.raises(AttributeError):
+        assert 9.0 < Millisatoshi(10)
+    with pytest.raises(AttributeError):
+        assert 9.0 <= Millisatoshi(10)
+    with pytest.raises(AttributeError):
+        assert 11.0 > Millisatoshi(10)
+    with pytest.raises(AttributeError):
+        assert 11.0 >= Millisatoshi(10)