aljaz/lightning
1
0
Fork 0
mirror of https://github.com/aljazceru/lightning.git synced 2025-12-19 15:14:23 +01:00
Code Issues Packages Projects Releases Wiki Activity

pytest: catch more gossip-related errors.

Browse Source 
Basically, any "Bad" message from gossipd is something we should look
at.  This covers failures loading the gossip_store, too!

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This commit is contained in:
Rusty Russell
2019-05-29 06:40:30 +09:30
committed by neil saitug
parent 45645e3a85
commit a40fe40ad2
1 changed files with 13 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
tests/fixtures.py
View File

@@ -132,8 +132,8 @@ def node_factory(request, directory, test_name, bitcoind, executor):
check_errors(request, err_count, "{} nodes had unexpected reconnections") check_errors(request, err_count, "{} nodes had unexpected reconnections")
for node in nf.nodes: for node in nf.nodes:
err_count += checkBadGossipOrder(node) err_count += checkBadGossip(node)
check_errors(request, err_count, "{} nodes had bad gossip order") check_errors(request, err_count, "{} nodes had bad gossip messages")
for node in nf.nodes: for node in nf.nodes:
err_count += checkBadReestablish(node) err_count += checkBadReestablish(node)
@@ -204,8 +204,17 @@ def checkReconnect(node):
return 0 return 0
def checkBadGossipOrder(node): def checkBadGossip(node):
if node.daemon.is_in_log('Bad gossip order from (?!error)') and not node.daemon.is_in_log('Deleting channel'): # We can get bad gossip order from inside error msgs.
if node.daemon.is_in_log('Bad gossip order from (?!error)'):
# This can happen if a node sees a node_announce after a channel
# is deleted, however.
if node.daemon.is_in_log('Deleting channel'):
return 0
return 1
# Other 'Bad' messages shouldn't happen.
if node.daemon.is_in_log(r'gossipd.*Bad (?!gossip order from error)'):
return 1 return 1
return 0 return 0