From 90dc5173d5654eb605a573c98593f2ffe5b1505a Mon Sep 17 00:00:00 2001 From: Rusty Russell Date: Fri, 18 May 2018 09:58:49 +0930 Subject: [PATCH] test_lightningd.py: remove 5 slowest tests from non-developer mode. We can restore them once we get parallel testing on Travis, but meanwhile we time out because of the 30 seconds bitcoind poll. Running on my laptop with --duration=5: =========================== slowest 5 test durations =========================== 184.07s call tests/test_lightningd.py::LightningDTests::test_multiple_channels 156.66s call tests/test_lightningd.py::LightningDTests::test_forward 155.77s call tests/test_lightningd.py::LightningDTests::test_closing 126.83s call tests/test_lightningd.py::LightningDTests::test_waitinvoice 126.11s call tests/test_lightningd.py::LightningDTests::test_waitanyinvoice Signed-off-by: Rusty Russell --- tests/test_lightningd.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tests/test_lightningd.py b/tests/test_lightningd.py index 62f1a11f8..8a906e696 100644 --- a/tests/test_lightningd.py +++ b/tests/test_lightningd.py @@ -1300,6 +1300,7 @@ class LightningDTests(BaseLightningDTests): l2.daemon.wait_for_log('to_self_delay 100 larger than 99') + @unittest.skipIf(not DEVELOPER, "Too slow without --dev-bitcoind-poll") def test_closing(self): l1, l2 = self.connect() @@ -2677,6 +2678,7 @@ class LightningDTests(BaseLightningDTests): seen.append((c['source'], c['destination'])) assert set(seen) == set(comb) + @unittest.skipIf(not DEVELOPER, "Too slow without --dev-bitcoind-poll") def test_forward(self): # Connect 1 -> 2 -> 3. l1, l2 = self.connect() @@ -3953,6 +3955,7 @@ class LightningDTests(BaseLightningDTests): assert not l2.daemon.is_in_log('signature verification failed') assert not l3.daemon.is_in_log('signature verification failed') + @unittest.skipIf(not DEVELOPER, "Too slow without --dev-bitcoind-poll") def test_waitinvoice(self): """Test waiting for one invoice will not return if another invoice is paid. @@ -3991,6 +3994,7 @@ class LightningDTests(BaseLightningDTests): time.sleep(1) assert not f3.done() + @unittest.skipIf(not DEVELOPER, "Too slow without --dev-bitcoind-poll") def test_waitanyinvoice(self): """Test various variants of waiting for the next invoice to complete. """ @@ -4353,6 +4357,7 @@ class LightningDTests(BaseLightningDTests): oneconfig = l1.rpc.listconfigs(config=c) assert(oneconfig[c] == configs[c]) + @unittest.skipIf(not DEVELOPER, "Too slow without --dev-bitcoind-poll") def test_multiple_channels(self): l1 = self.node_factory.get_node() l2 = self.node_factory.get_node()