From 6c4a438afdf86cebd26f8aa18f868564c8f64189 Mon Sep 17 00:00:00 2001 From: Rusty Russell Date: Tue, 7 Mar 2023 08:50:17 +1030 Subject: [PATCH] wallet: really allow broken migrations. e778ebb9af5a6157a4b605a77f87b2c48b9d03b0 ("wallet: only log broken if we have duplicate scids in channels.") downgraded the fatal() to a broken log message, but the user reports it still won't start up. Perhaps they're hitting the fatal() outside the loop? (And we're not getting that output). Signed-off-by: Rusty Russell --- wallet/db.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/wallet/db.c b/wallet/db.c index 5a5a1c78f..ea2e2d067 100644 --- a/wallet/db.c +++ b/wallet/db.c @@ -1532,8 +1532,8 @@ static void migrate_channels_scids_as_integers(struct lightningd *ld, } if (changes != tal_count(scids)) - fatal("migrate_channels_scids_as_integers: only converted %zu of %zu scids!", - changes, tal_count(scids)); + log_broken(ld->log, "migrate_channels_scids_as_integers: only converted %zu of %zu scids!", + changes, tal_count(scids)); /* FIXME: We cannot use ->delete_columns to remove * short_channel_id, as other tables reference the channels