aljaz/lightning
1
0
Fork 0
mirror of https://github.com/aljazceru/lightning.git synced 2025-12-19 07:04:22 +01:00
Code Issues Packages Projects Releases Wiki Activity

pytest: fix timeout in test_option_types

Browse Source 
We were waiting for the start to timeout waiting for the "public key"
message.  Instead, start manually.

Before, this took (with TIMEOUT=30) 97 seconds, after 8 seconds.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This commit is contained in:
Rusty Russell
2022-06-26 14:15:01 +09:30
parent 61d8eb5fa8
commit 6221ac621d
1 changed files with 9 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
tests/test_plugin.py
View File

@@ -91,9 +91,10 @@ def test_option_types(node_factory):
'str_opt': 'ok',
'int_opt': 22,
'bool_opt': '!',
}, expect_fail=True, may_fail=True)
}, may_fail=True, start=False)
# the node should fail to start, and we get a stderr msg
# the node should fail after start, and we get a stderr msg
n.daemon.start(wait_for_initialized=False)
assert n.daemon.wait() == 1
wait_for(lambda: n.daemon.is_in_stderr('bool_opt: ! does not parse as type bool'))
@@ -103,9 +104,10 @@ def test_option_types(node_factory):
'str_opt': 'ok',
'int_opt': 'notok',
'bool_opt': 1,
}, may_fail=True, expect_fail=True)
}, may_fail=True, start=False)
# the node should fail to start, and we get a stderr msg
# the node should fail after start, and we get a stderr msg
n.daemon.start(wait_for_initialized=False)
assert n.daemon.wait() == 1
assert n.daemon.is_in_stderr('--int_opt: notok does not parse as type int')
@@ -116,9 +118,10 @@ def test_option_types(node_factory):
'int_opt': 11,
'bool_opt': 1,
'flag_opt': True,
}, may_fail=True, expect_fail=True)
}, may_fail=True, start=False)
# the node should fail to start, and we get a stderr msg
# the node should fail after start, and we get a stderr msg
n.daemon.start(wait_for_initialized=False)
assert n.daemon.wait() == 1
assert n.daemon.is_in_stderr("--flag_opt: doesn't allow an argument")