aljaz/lightning
1
0
Fork 0
mirror of https://github.com/aljazceru/lightning.git synced 2025-12-20 07:34:24 +01:00
Code Issues Packages Projects Releases Wiki Activity

plugins: fix error report from bitcoin-cli exec failure.

Browse Source 
We've stomped errno, so if exec fails we don't get a reliable result:

```
2023-08-07T17:58:45.713Z **BROKEN** plugin-bcli: bitcoin-cli exec failed: Bad file descriptor
```

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This commit is contained in:
Rusty Russell
2023-08-08 06:58:10 +09:30
parent 961ad21281
commit 5f8b77480c
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
plugins/bcli.c
View File

@@ -298,16 +298,16 @@ static void next_bcli(enum bitcoind_prio prio)
bcli->pid = pipecmdarr(&in, &bcli->fd, &bcli->fd, bcli->pid = pipecmdarr(&in, &bcli->fd, &bcli->fd,
cast_const2(char **, bcli->args)); cast_const2(char **, bcli->args));
if (bcli->pid < 0)
plugin_err(bcli->cmd->plugin, "%s exec failed: %s",
bcli->args[0], strerror(errno));
if (bitcoind->rpcpass) if (bitcoind->rpcpass)
write_all(in, bitcoind->rpcpass, strlen(bitcoind->rpcpass)); write_all(in, bitcoind->rpcpass, strlen(bitcoind->rpcpass));
close(in); close(in);
if (bcli->pid < 0)
plugin_err(bcli->cmd->plugin, "%s exec failed: %s",
bcli->args[0], strerror(errno));
bcli->start = time_now(); bcli->start = time_now();
bitcoind->num_requests[prio]++; bitcoind->num_requests[prio]++;