From 572d71c50e00eb0426847e7fedbb173f76f1e9f8 Mon Sep 17 00:00:00 2001 From: Adi Shankara <85787690+adi-shankara@users.noreply.github.com> Date: Tue, 1 Aug 2023 17:19:29 +0530 Subject: [PATCH] fix readme workflow (yet again) and test a dummy change (#6477) --- .github/workflows/rdme-docs-sync.yml | 23 +++++++++++-------- .../tracing-cln-performance.md | 2 ++ 2 files changed, 15 insertions(+), 10 deletions(-) diff --git a/.github/workflows/rdme-docs-sync.yml b/.github/workflows/rdme-docs-sync.yml index eb848a577..dff1cdcb2 100644 --- a/.github/workflows/rdme-docs-sync.yml +++ b/.github/workflows/rdme-docs-sync.yml @@ -1,16 +1,14 @@ name: ReadMe Sync on: - pull_request_target: - types: - - closed + push: branches: - 'master' paths: - - 'doc/' + - 'doc/**' jobs: - rdme-docs: + rdme-docs-sync: runs-on: ubuntu-latest steps: - name: Check out repo 📚 @@ -19,24 +17,29 @@ jobs: - name: Sync doc/getting-started/ 🚀 uses: readmeio/rdme@v8 with: - rdme: docs doc/getting-started --key=${{ secrets.README_API_KEY }} --version=1 + README_API_KEY: ${{ secrets.README_API_KEY }} + rdme: docs doc/getting-started --key=$README_API_KEY --version=1 - name: Sync doc/beginners-guide/ 🚀 uses: readmeio/rdme@v8 with: - rdme: docs doc/beginners-guide --key=${{ secrets.README_API_KEY }} --version=1 + README_API_KEY: ${{ secrets.README_API_KEY }} + rdme: docs doc/beginners-guide --key=$README_API_KEY --version=1 - name: Sync doc/node-operators-guide/ 🚀 uses: readmeio/rdme@v8 with: - rdme: docs doc/node-operators-guide --key=${{ secrets.README_API_KEY }} --version=1 + README_API_KEY: ${{ secrets.README_API_KEY }} + rdme: docs doc/node-operators-guide --key=$README_API_KEY --version=1 - name: Sync doc/developers-guide/ 🚀 uses: readmeio/rdme@v8 with: - rdme: docs doc/developers-guide --key=${{ secrets.README_API_KEY }} --version=1 + README_API_KEY: ${{ secrets.README_API_KEY }} + rdme: docs doc/developers-guide --key=$README_API_KEY --version=1 - name: Sync doc/contributing-to-core-lightning/ 🚀 uses: readmeio/rdme@v8 with: - rdme: docs doc/contributing-to-core-lightning --key=${{ secrets.README_API_KEY }} --version=1 + README_API_KEY: ${{ secrets.README_API_KEY }} + rdme: docs doc/contributing-to-core-lightning --key=$README_API_KEY --version=1 diff --git a/doc/developers-guide/tracing-cln-performance.md b/doc/developers-guide/tracing-cln-performance.md index ca255dd62..2c80413bc 100644 --- a/doc/developers-guide/tracing-cln-performance.md +++ b/doc/developers-guide/tracing-cln-performance.md @@ -76,4 +76,6 @@ Attaching 1 probe... ``` + + Notice that due to a [limitation](https://github.com/iovisor/bpftrace/issues/305) in `bpftrace` you'll at most get the first 200 bytes of the payload. If you write your own exporter you'll be able to specify the size of the buffer that is being used, and can extract the entire span.