aljaz/lightning
1
0
Fork 0
mirror of https://github.com/aljazceru/lightning.git synced 2026-01-27 09:44:28 +01:00
Code Issues Packages Projects Releases Wiki Activity

plugins: allow plugins to disable themselves at startup.

Browse Source 
By returning 'disable: <reason>' inside getmanifest or init result.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Changelog-Added: plugins: plugins can now disable themselves by returning `disable`, even if marked important.
This commit is contained in:
Rusty Russell
2021-01-13 13:30:24 +10:30
committed by Christian Decker
parent fc3e679c97
commit 529ae0d766
5 changed files with 104 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
tests/test_plugin.py
View File

@@ -2321,3 +2321,24 @@ def test_pyln_request_notify(node_factory):
notifications = []
l1.rpc.countdown(10)
assert notifications == []
def test_self_disable(node_factory):
"""Test that plugin can disable itself without penalty.
"""
plugin_path = os.path.join(
os.path.dirname(__file__), 'plugins/test_selfdisable'
)
l1 = node_factory.get_node(options={'important-plugin': plugin_path})
# Could happen before it gets set up.
l1.daemon.logsearch_start = 0
l1.daemon.wait_for_log('test_selfdisable: disabled itself: "Self-disable test after getmanifest"')
assert plugin_path not in [p['name'] for p in l1.rpc.plugin_list()['plugins']]
# Also works with dynamic load attempts
with pytest.raises(RpcError, match="Self-disable test after getmanifest"):
l1.rpc.plugin_start(plugin_path)
# Now test the disable-in-init-response.