aljaz/lightning
1
0
Fork 0
mirror of https://github.com/aljazceru/lightning.git synced 2025-12-20 15:44:21 +01:00
Code Issues Packages Projects Releases Wiki Activity

pytest: fix flake in test_feerates

Browse Source 
```
2023-07-14T05:32:54.3688763Z         # Set ECONOMICAL/6 feerate, for unilateral_close and htlc_resolution
2023-07-14T05:32:54.3689123Z         l1.set_feerates((15000, 11000, 0, 0), True)
2023-07-14T05:32:54.3689484Z         feerates = l1.rpc.feerates('perkw')
2023-07-14T05:32:54.3689919Z >       assert feerates['perkw']['unilateral_close'] == 11000
2023-07-14T05:32:54.3690226Z E       assert 15000 == 11000
2023-07-14T05:32:54.3690391Z
2023-07-14T05:32:54.3690514Z tests/test_misc.py:1572: AssertionError
```

The rough checks in set_feerates don't actually ensure that we've digested
the changes, so copy the check from elsewhere that makes sure
feerates['estimates'] has indeed been updated.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This commit is contained in:
Rusty Russell
2023-07-15 14:04:22 +09:30
parent 1ddf4bac2c
commit 5151020224
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
tests/test_misc.py
View File

@@ -1555,11 +1555,14 @@ def test_feerates(node_factory, anchors):
# Now try setting them, one at a time. # Now try setting them, one at a time.
# Set CONSERVATIVE/2 feerate, for max # Set CONSERVATIVE/2 feerate, for max
l1.set_feerates((15000, 0, 0, 0), True) l1.set_feerates((15000, 0, 0, 0), True)
wait_for(lambda: l1.rpc.feerates('perkw')['perkw']['max_acceptable'] == 15000 * 10) # Make sure it's digested the bcli plugin results.
wait_for(lambda: len(l1.rpc.feerates('perkw')['perkw']['estimates']) == 1)
feerates = l1.rpc.feerates('perkw') feerates = l1.rpc.feerates('perkw')
# We only get the warning if *no* feerates are avail. # We only get the warning if *no* feerates are avail.
assert 'warning_missing_feerates' not in feerates assert 'warning_missing_feerates' not in feerates
assert 'perkb' not in feerates assert 'perkb' not in feerates
assert feerates['perkw']['max_acceptable'] == 15000 * 10
# With only one data point, this is a terrible guess! # With only one data point, this is a terrible guess!
assert feerates['perkw']['min_acceptable'] == 15000 // 2 assert feerates['perkw']['min_acceptable'] == 15000 // 2
assert feerates['perkw']['estimates'] == [{'blockcount': 2, assert feerates['perkw']['estimates'] == [{'blockcount': 2,
@@ -1568,6 +1571,8 @@ def test_feerates(node_factory, anchors):
# Set ECONOMICAL/6 feerate, for unilateral_close and htlc_resolution # Set ECONOMICAL/6 feerate, for unilateral_close and htlc_resolution
l1.set_feerates((15000, 11000, 0, 0), True) l1.set_feerates((15000, 11000, 0, 0), True)
# Make sure it's digested the bcli plugin results.
wait_for(lambda: len(l1.rpc.feerates('perkw')['perkw']['estimates']) == 2)
feerates = l1.rpc.feerates('perkw') feerates = l1.rpc.feerates('perkw')
assert feerates['perkw']['unilateral_close'] == 11000 assert feerates['perkw']['unilateral_close'] == 11000
assert 'warning_missing_feerates' not in feerates assert 'warning_missing_feerates' not in feerates
@@ -1584,6 +1589,8 @@ def test_feerates(node_factory, anchors):
# Set ECONOMICAL/12 feerate, for all but min (so, no mutual_close feerate) # Set ECONOMICAL/12 feerate, for all but min (so, no mutual_close feerate)
l1.set_feerates((15000, 11000, 6250, 0), True) l1.set_feerates((15000, 11000, 6250, 0), True)
# Make sure it's digested the bcli plugin results.
wait_for(lambda: len(l1.rpc.feerates('perkw')['perkw']['estimates']) == 3)
feerates = l1.rpc.feerates('perkb') feerates = l1.rpc.feerates('perkb')
assert feerates['perkb']['unilateral_close'] == 11000 * 4 assert feerates['perkb']['unilateral_close'] == 11000 * 4
# We dont' extrapolate, so it uses the same for mutual_close # We dont' extrapolate, so it uses the same for mutual_close