aljaz/lightning
1
0
Fork 0
mirror of https://github.com/aljazceru/lightning.git synced 2026-01-21 23:04:22 +01:00
Code Issues Packages Projects Releases Wiki Activity

lightningd: add zbase32 encoding to signmessage

Browse Source 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This commit is contained in:
Rusty Russell
2019-10-12 15:42:50 +10:30
committed by neil saitug
parent fc9a2a5dba
commit 3955ddfce6
1 changed files with 41 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

46
lightningd/signmessage.c
View File

@@ -1,3 +1,4 @@
#include <common/bech32.h>
#include <common/json_helpers.h> #include <common/json_helpers.h>
#include <common/jsonrpc_errors.h> #include <common/jsonrpc_errors.h>
#include <common/param.h> #include <common/param.h>
@@ -9,6 +10,31 @@
#include <string.h> #include <string.h>
#include <wire/wire_sync.h> #include <wire/wire_sync.h>
/* These tables copied from zbase32 src:
* copyright 2002-2007 Zooko "Zooko" Wilcox-O'Hearn
* mailto:zooko@zooko.com
*
* Permission is hereby granted to any person obtaining a copy of this work to
* deal in this work without restriction (including the rights to use, modify,
* distribute, sublicense, and/or sell copies).
*/
static const char*const zbase32_chars="ybndrfg8ejkmcpqxot1uwisza345h769";
static const char *to_zbase32(const tal_t *ctx, const u8 *msg, size_t srclen)
{
size_t outlen;
char *out = tal_arr(ctx, char, (srclen * 8 + 4) / 5 + 1);
outlen = 0;
if (!bech32_convert_bits((uint8_t *)out, &outlen, 5, msg, srclen, 8, true))
return tal_free(out);
assert(outlen < tal_bytelen(out));
for (size_t i = 0; i < outlen; i++)
out[i] = zbase32_chars[(unsigned)out[i]];
out[outlen] = '\0';
return out;
}
static struct command_result *json_signmessage(struct command *cmd, static struct command_result *json_signmessage(struct command *cmd,
const char *buffer, const char *buffer,
const jsmntok_t *obj UNNEEDED, const jsmntok_t *obj UNNEEDED,
@@ -17,7 +43,7 @@ static struct command_result *json_signmessage(struct command *cmd,
const char *message; const char *message;
secp256k1_ecdsa_recoverable_signature rsig; secp256k1_ecdsa_recoverable_signature rsig;
struct json_stream *response; struct json_stream *response;
u8 sig[64], recidu8, *msg; u8 sig[65], *msg;
int recid; int recid;
if (!param(cmd, buffer, params, if (!param(cmd, buffer, params,
@@ -41,12 +67,22 @@ static struct command_result *json_signmessage(struct command *cmd,
tal_hex(msg, msg)); tal_hex(msg, msg));
secp256k1_ecdsa_recoverable_signature_serialize_compact(secp256k1_ctx, secp256k1_ecdsa_recoverable_signature_serialize_compact(secp256k1_ctx,
sig, &recid, sig+1, &recid,
&rsig); &rsig);
response = json_stream_success(cmd); response = json_stream_success(cmd);
json_add_hex(response, "signature", sig, sizeof(sig)); json_add_hex(response, "signature", sig+1, sizeof(sig)-1);
recidu8 = recid; sig[0] = recid;
json_add_hex(response, "recid", &recidu8, sizeof(recidu8)); json_add_hex(response, "recid", sig, 1);
/* From https://twitter.com/rusty_twit/status/1182102005914800128:
* @roasbeef & @bitconner point out that #lnd algo is:
* zbase32(SigRec(SHA256(SHA256("Lightning Signed Message:" + msg)))).
* zbase32 from https://philzimmermann.com/docs/human-oriented-base-32-encoding.txt
* and SigRec has first byte 31 + recovery id, followed by 64 byte sig.
* #specinatweet */
sig[0] += 31;
json_add_string(response, "zbase",
to_zbase32(response, sig, sizeof(sig)));
return command_success(cmd, response); return command_success(cmd, response);
} }