CI: clean up workflow files.

We used to have to use environment variables to pass through to
github/scripts/build.sh, but now we run ./configure directly it's
clearer to use explicit flags (though some matrixes still use env vars
for simplicity).

We also don't need to set COMPAT, as it's the default (MacOS tests
that we build without it, but otherwise we assume it's on).

And we make `gather` actually depend on all the other steps!

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

.github/workflows/bsd.yml

@@ -11,17 +11,12 @@ jobs:
     runs-on: macos-10.15
     name: Build and test on FreeBSD
     timeout-minutes: 120
-    env:
-      DEVELOPER: 1
-      VALGRIND: 0
-      COMPAT: 1
     steps:
     - uses: actions/checkout@v2
     - name: Test in FreeBSD
       id: test
       uses: vmactions/freebsd-vm@v0.1.5
       with:
-        envs: 'DEVELOPER VALGRIND COMPAT'
         usesh: true
         prepare: |
           pkg install -y \
@@ -73,7 +68,8 @@ jobs:
           git config --global --add safe.directory `pwd`
           git submodule update --init --recursive
 
-          ./configure CC="$CC"
+          ./configure CC="$CC" --enable-developer --disable-valgrind
+
           cat config.vars
 
           cat << EOF > pytest.ini