cli: change the redefine logic to read from the stdin

Procedure redefinition is a very cool feature but when other libraries redefine the same function can be very tricky to avoid compilation error.

This PR proposed a change of logic and use a customizzation function definition to read from the stdin, so we can avoid future error at compile time.

However, we could be check also the os or compiler that cause the error and redefine the missing function.

Changelog-None: Fixed compilation error due redefinition procedure.

Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
This commit is contained in:
Vincenzo Palazzo
2022-01-12 21:36:56 +01:00
committed by Christian Decker
parent 52b1f5a8f4
commit 35eaaf8e63
6 changed files with 33 additions and 8 deletions

15
cli/config_cli.h Normal file
View File

@@ -0,0 +1,15 @@
#ifndef LIGHTNING_CLI_CONFIG_CLI_H
#define LIGHTNING_CLI_CONFIG_CLI_H
#include "config.h"
#include <stdio.h>
#ifndef CLN_TEST
/* Redefinition procedure is a very cool feature, but
if we try to redefine a procedure that is already
redefined somewhere (like read in alpine) we can have
tricky compilation error */
#define cli_read read
#endif
#endif /* LIGHTNING_CLI_CONFIG_CLI_H */