From 32215177fef0f672c29f70a2e3808b108544dfc6 Mon Sep 17 00:00:00 2001 From: Rusty Russell Date: Mon, 8 Apr 2019 11:23:16 +0930 Subject: [PATCH] pytest: more testing for local socket addresses. In particular, the assert when `--addr=/sockname` is used, and that it doesn't clean up on restart, requiring manual deletion of the socket. Signed-off-by: Rusty Russell --- tests/test_misc.py | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/tests/test_misc.py b/tests/test_misc.py index 481cd70ab..1d40cf7e9 100644 --- a/tests/test_misc.py +++ b/tests/test_misc.py @@ -566,6 +566,7 @@ def test_io_logging(node_factory, executor): assert any(l['type'] == 'IO_IN' for l in peerlog) +@pytest.mark.xfail(strict=True) def test_address(node_factory): if DEVELOPER: opts = {'dev-allow-localhost': None} @@ -595,6 +596,16 @@ def test_address(node_factory): l2 = node_factory.get_node() l2.rpc.connect(l1.info['id'], l1.daemon.opts['bind-addr']) + # 'addr' with local socket works too. + l1.stop() + del l1.daemon.opts['bind-addr'] + l1.daemon.opts['addr'] = os.path.join(l1.daemon.lightning_dir, "sock") + # start expects a port, so we open-code here. + l1.daemon.start() + + l2 = node_factory.get_node() + l2.rpc.connect(l1.info['id'], l1.daemon.opts['addr']) + def test_listconfigs(node_factory, bitcoind): l1 = node_factory.get_node()