aljaz/lightning
1
0
Fork 0
mirror of https://github.com/aljazceru/lightning.git synced 2025-12-24 01:24:26 +01:00
Code Issues Packages Projects Releases Wiki Activity

opts: deprecate --disable-ip-discovery switch

Browse Source 
This switch was not doing anything useful anymore.
We deprecate it anyways to notify the user about the new switch.

Changelog-Deprecated: The old --disable-ip-discovery config switch
This commit is contained in:
Michael Schmoock
2022-12-20 18:28:46 +01:00
parent a2b94f16f8
commit 30dea0a431
6 changed files with 14 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
lightningd/options.c
View File

@@ -845,8 +845,6 @@ static const struct config testnet_config = {
/* Excplicitly turns 'on' or 'off' IP discovery feature. */
.ip_discovery = OPT_AUTOBOOL_AUTO,
/* Turn off IP address announcement discovered via peer `remote_addr` */
.disable_ip_discovery = false,
/* Sets min_effective_htlc_capacity - at 1000$/BTC this is 10ct */
.min_capacity_sat = 10000,
@@ -913,8 +911,6 @@ static const struct config mainnet_config = {
/* Excplicitly turns 'on' or 'off' IP discovery feature. */
.ip_discovery = OPT_AUTOBOOL_AUTO,
/* Turn off IP address announcement discovered via peer `remote_addr` */
.disable_ip_discovery = false,
/* Sets min_effective_htlc_capacity - at 1000$/BTC this is 10ct */
.min_capacity_sat = 10000,
@@ -1084,6 +1080,13 @@ static char *opt_set_db_upgrade(const char *arg, struct lightningd *ld)
return opt_set_bool_arg(arg, ld->db_upgrade_ok);
}
static char *opt_disable_ip_discovery(struct lightningd *ld)
{
log_broken(ld->log, "--disable-ip-discovery has been deprecated, use --announce-addr-discovered=false");
ld->config.ip_discovery = OPT_AUTOBOOL_FALSE;
return NULL;
}
static void register_opts(struct lightningd *ld)
{
/* This happens before plugins started */
@@ -1216,9 +1219,7 @@ static void register_opts(struct lightningd *ld)
ld,
"Set an IP address (v4 or v6) or .onion v3 to announce, but not listen on");
opt_register_noarg("--disable-ip-discovery", opt_set_bool,
&ld->config.disable_ip_discovery,
"Turn off announcement of discovered public IPs");
opt_register_noarg("--disable-ip-discovery", opt_disable_ip_discovery, ld, opt_hidden);
opt_register_arg("--announce-addr-discovered", opt_set_autobool_arg, opt_show_autobool,
&ld->config.ip_discovery,
"Explicitly turns IP discovery 'on' or 'off'.");