From 2c88ab53d4939981e31565e0138ad3d4684bb906 Mon Sep 17 00:00:00 2001 From: Rusty Russell Date: Wed, 12 Feb 2020 14:08:30 +1030 Subject: [PATCH] doc: update MAKING-RELEASES. 1. GH_TOKEN is probably required to run the changelog script. 2. Note the footnotes need updating; we no longer have [Unreleased]. Signed-off-by: Rusty Russell --- doc/MAKING-RELEASES.md | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/doc/MAKING-RELEASES.md b/doc/MAKING-RELEASES.md index b225696b1..864e4af47 100644 --- a/doc/MAKING-RELEASES.md +++ b/doc/MAKING-RELEASES.md @@ -24,10 +24,12 @@ Here's a checklist for the release process. & coolness. 2. Use `devtools/changelog.py` to collect the changelog entries from pull request commit messages and merge them into the manually maintained - `CHANGELOG.md`. -3. Update the CHANGELOG.md with [Unreleased] changed to v-rc1. Note that - you should exactly copy the date and name format from a previous - release, as the `build-release.sh` script relies on this. + `CHANGELOG.md`. This does API queries to GitHub, which are severely + ratelimited unless you use an API token: set the `GH_TOKEN` environment + variable to a Personal Access Token from https://github.com/settings/tokens +3. Create a new CHANGELOG.md heading to v-rc1, and create a link at + the bottom. Note that you should exactly copy the date and name format from + a previous release, as the `build-release.sh` script relies on this. 4. Create a PR with the above. ### Releasing -rc1