aljaz/lightning
1
0
Fork 0
mirror of https://github.com/aljazceru/lightning.git synced 2026-01-08 00:24:28 +01:00
Code Issues Packages Projects Releases Wiki Activity

doc: fix up bolt12 quotes.

Browse Source 
The one about size needs the offers PR rebased onto the latest
onion-message PR.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This commit is contained in:
Rusty Russell
2021-07-05 20:57:39 +09:30
committed by neil saitug
parent 3b40bfa801
commit 2aa833d424
5 changed files with 9 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
plugins/fetchinvoice.c
View File

@@ -496,10 +496,9 @@ static struct command_result *param_offer(struct command *cmd,
/* BOLT-offers #12:
*
* - if `node_id`, `description` or `signature` is not set:
* - if `node_id` or `description` is not set:
* - MUST NOT respond to the offer.
*/
/* Note: offer_decode checks `signature` */
if (!(*offer)->node_id)
return command_fail_badparam(cmd, name, buffer, tok,
"Offer does not contain a node_id");
@@ -925,7 +924,7 @@ static struct command_result *json_fetchinvoice(struct command *cmd,
sent->wait_timeout = *timeout;
/* BOLT-offers #12:
* - MUST set `offer_id` to the merkle root of the offer as described
* - MUST set `offer_id` to the Merkle root of the offer as described
* in [Signature Calculation](#signature-calculation).
*/
invreq->offer_id = tal(invreq, struct sha256);
@@ -1043,7 +1042,6 @@ static struct command_result *json_fetchinvoice(struct command *cmd,
/* BOLT-offers #12:
* - otherwise:
* - MUST NOT set `recurrence_counter`.
*...
* - MUST NOT set `recurrence_start`
*/
if (invreq->recurrence_counter)

2
plugins/offers.c
View File

@@ -311,7 +311,7 @@ static void json_add_offer(struct json_stream *js, const struct tlv_offer *offer
/* BOLT-offers #12:
* A reader of an offer:
*...
* - if `node_id`, `description` or `signature` is not set:
* - if `node_id` or `description` is not set:
* - MUST NOT respond to the offer.
*/
if (offer->description)

6
plugins/offers_invreq_hook.c
View File

@@ -480,7 +480,7 @@ static struct command_result *invreq_base_amount_simple(struct command *cmd,
* - otherwise:
* - MUST fail the request if it does not contain `amount`.
* - MUST use the request `amount` as the *base invoice amount*.
* (Note: invoice amount can be further modiifed by recurrence
* (Note: invoice amount can be further modified by recurrence
* below)
*/
err = invreq_must_have(cmd, ir, amount);
@@ -728,10 +728,6 @@ static struct command_result *listoffers_done(struct command *cmd,
* - if the offer had a `recurrence`:
* - MUST fail the request if there is no `recurrence_counter`
* field.
* - MUST fail the request if there is no
* `recurrence_signature` field.
* - MUST fail the request if `recurrence_signature` is not
* correct.
*/
err = invreq_must_have(cmd, ir, recurrence_counter);
if (err)