aljaz/lightning
1
0
Fork 0
mirror of https://github.com/aljazceru/lightning.git synced 2025-12-19 15:14:23 +01:00
Code Issues Packages Projects Releases Wiki Activity

option_data_loss_protect: reenable by default

Browse Source
This commit is contained in:
lisa neigut
2019-01-20 10:18:10 -08:00
committed by Rusty Russell
parent 4a45caae32
commit 28699f0eca
3 changed files with 3 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG.md
View File

@@ -21,6 +21,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- The `short_channel_id` separator has been changed to be `x` to match the specification. - The `short_channel_id` separator has been changed to be `x` to match the specification.
- JSON API: `listpeers` now includes `funding_allocation_msat`, which returns a map of the amounts initially funded to the channel by each peer, indexed by channel id. - JSON API: `listpeers` now includes `funding_allocation_msat`, which returns a map of the amounts initially funded to the channel by each peer, indexed by channel id.
- `option_data_loss_protect` is now enabled by default.
### Deprecated ### Deprecated

2
common/features.c
View File

@@ -4,9 +4,7 @@
#include <wire/peer_wire.h> #include <wire/peer_wire.h>
static const u32 our_localfeatures[] = { static const u32 our_localfeatures[] = {
#if EXPERIMENTAL_FEATURES
LOCAL_DATA_LOSS_PROTECT, LOCAL_DATA_LOSS_PROTECT,
#endif
LOCAL_INITIAL_ROUTING_SYNC, LOCAL_INITIAL_ROUTING_SYNC,
LOCAL_GOSSIP_QUERIES LOCAL_GOSSIP_QUERIES
}; };

8
tests/test_connection.py
View File

@@ -1,7 +1,7 @@
from collections import namedtuple from collections import namedtuple
from fixtures import * # noqa: F401,F403 from fixtures import * # noqa: F401,F403
from lightning import RpcError from lightning import RpcError
from utils import DEVELOPER, only_one, wait_for, sync_blockheight, VALGRIND, EXPERIMENTAL_FEATURES from utils import DEVELOPER, only_one, wait_for, sync_blockheight, VALGRIND
import os import os
@@ -1009,10 +1009,7 @@ def test_forget_channel(node_factory):
def test_peerinfo(node_factory, bitcoind): def test_peerinfo(node_factory, bitcoind):
l1, l2 = node_factory.line_graph(2, fundchannel=False, opts={'may_reconnect': True}) l1, l2 = node_factory.line_graph(2, fundchannel=False, opts={'may_reconnect': True})
if EXPERIMENTAL_FEATURES: lfeatures = '8a'
lfeatures = '8a'
else:
lfeatures = '88'
# Gossiping but no node announcement yet # Gossiping but no node announcement yet
assert l1.rpc.getpeer(l2.info['id'])['connected'] assert l1.rpc.getpeer(l2.info['id'])['connected']
assert len(l1.rpc.getpeer(l2.info['id'])['channels']) == 0 assert len(l1.rpc.getpeer(l2.info['id'])['channels']) == 0
@@ -1255,7 +1252,6 @@ def test_funder_simple_reconnect(node_factory, bitcoind):
@unittest.skipIf(not DEVELOPER, "needs LIGHTNINGD_DEV_LOG_IO") @unittest.skipIf(not DEVELOPER, "needs LIGHTNINGD_DEV_LOG_IO")
@unittest.skipIf(not EXPERIMENTAL_FEATURES, "needs option_data_loss_protect")
def test_dataloss_protection(node_factory, bitcoind): def test_dataloss_protection(node_factory, bitcoind):
l1 = node_factory.get_node(may_reconnect=True, log_all_io=True, l1 = node_factory.get_node(may_reconnect=True, log_all_io=True,
feerates=(7500, 7500, 7500)) feerates=(7500, 7500, 7500))