aljaz/lightning
1
0
Fork 0
mirror of https://github.com/aljazceru/lightning.git synced 2025-12-19 07:04:22 +01:00
Code Issues Packages Projects Releases Wiki Activity

plugins/sql: pay attention to deprecated in schema.

Browse Source 
For now, we ignore every deprecated field, but put in the logic so
that future deprecations will work as expected.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This commit is contained in:
Rusty Russell
2023-01-30 16:54:18 +10:30
committed by Alex Myers
parent 40fe893172
commit 20654ebd49
2 changed files with 52 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
tests/test_plugin.py
View File

@@ -3539,10 +3539,6 @@ def test_sql(node_factory, bitcoind):
'type': 'string'},
{'name': 'closer',
'type': 'string'},
{'name': 'funding_local_msat',
'type': 'msat'},
{'name': 'funding_remote_msat',
'type': 'msat'},
{'name': 'funding_pushed_msat',
'type': 'msat'},
{'name': 'funding_local_funds_msat',
@@ -3787,3 +3783,26 @@ def test_sql(node_factory, bitcoind):
wait_for(lambda: len(l3.rpc.listchannels()['channels']) == 2)
assert len(l3.rpc.sql("SELECT * FROM channels;")['rows']) == 2
l3.daemon.wait_for_log("Deleting channel: {}".format(scid))
# No deprecated fields!
with pytest.raises(RpcError, match='query failed with no such column: funding_local_msat'):
l2.rpc.sql("SELECT funding_local_msat FROM peerchannels;")
with pytest.raises(RpcError, match='query failed with no such column: funding_remote_msat'):
l2.rpc.sql("SELECT funding_remote_msat FROM peerchannels;")
with pytest.raises(RpcError, match='query failed with no such table: peers_channels'):
l2.rpc.sql("SELECT * FROM peers_channels;")
def test_sql_deprecated(node_factory, bitcoind):
# deprecated-apis breaks schemas...
l1 = node_factory.get_node(start=False, options={'allow-deprecated-apis': True})
l1.rpc.check_request_schemas = False
l1.start()
# FIXME: we have no fields which have been deprecated since sql plugin was
# introduced. When we do, add them here! (I manually tested a fake one)
# ret = l1.rpc.sql("SELECT funding_local_msat, funding_remote_msat FROM peerchannels;")
# assert ret == {'rows': []}