common/gossmap: don't memcpy NULL, 0, and don't add 0 to NULL pointer.

Of course, NULL and length 0 are natural partners, but We Can't Have Nice Things.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This commit is contained in:
Rusty Russell
2023-04-01 14:10:23 +10:30
parent 3be36a66e3
commit 2005ca436e
2 changed files with 7 additions and 3 deletions

View File

@@ -808,7 +808,9 @@ bool gossmap_local_addchan(struct gossmap_localmods *localmods,
be16 = cpu_to_be16(tal_bytelen(features));
memcpy(localmods->local + off, &be16, sizeof(be16));
off += sizeof(be16);
memcpy(localmods->local + off, features, tal_bytelen(features));
/* Damn you, C committee! */
if (features)
memcpy(localmods->local + off, features, tal_bytelen(features));
off += tal_bytelen(features);
/* Skip chain_hash */