aljaz/lightning
1
0
Fork 0
mirror of https://github.com/aljazceru/lightning.git synced 2025-12-18 22:54:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

lightningd: use fsync not fdatasync.

Browse Source 
Apparently MacOS doesn't always have fdatasync, so use fsync.  Even more importantly
check whether it succeeds!

Fixes: #6516
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This commit is contained in:
Rusty Russell
2023-08-07 12:29:58 +09:30
parent 98c805e267
commit 1fbe87f6e4
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
lightningd/configs.c
View File

@@ -504,7 +504,8 @@ static bool configfile_replace_var(struct lightningd *ld,
contents = tal_strjoin(tmpctx, take(lines), "\n", STR_TRAIL); contents = tal_strjoin(tmpctx, take(lines), "\n", STR_TRAIL);
if (!write_all(outfd, contents, strlen(contents))) if (!write_all(outfd, contents, strlen(contents)))
fatal("Writing %s: %s", template, strerror(errno)); fatal("Writing %s: %s", template, strerror(errno));
fdatasync(outfd); if (fsync(outfd) != 0)
fatal("Syncing %s: %s", template, strerror(errno));
if (rename(template, cv->file) != 0) if (rename(template, cv->file) != 0)
fatal("Renaming %s over %s: %s", fatal("Renaming %s over %s: %s",