aljaz/lightning
1
0
Fork 0
mirror of https://github.com/aljazceru/lightning.git synced 2025-12-24 01:24:26 +01:00
Code Issues Packages Projects Releases Wiki Activity

gossipd: don't send updates in error messages for unannounced channels.

Browse Source 
This restores the behaviour prior to `lightningd: use our cached
channel_update for errors instead of asking gossipd.`, where gossipd
would refuse to give us channel_updates for unannounced channels.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This commit is contained in:
Rusty Russell
2022-02-08 11:16:52 +10:30
parent d56904db80
commit 1da9b30b9a
2 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
gossipd/gossip_generation.c
View File

@@ -420,9 +420,13 @@ static u8 *sign_and_timestamp_update(const tal_t *ctx,
tal_free(unsigned_update); tal_free(unsigned_update);
/* Tell lightningd about this immediately (even if we're not actually /* Tell lightningd about this immediately (even if we're not actually
* applying it now) */ * applying it now). We choose not to send info about private
msg = towire_gossipd_got_local_channel_update(NULL, &chan->scid, update); * channels, even in errors. */
daemon_conn_send(daemon->master, take(msg)); if (is_chan_public(chan)) {
msg = towire_gossipd_got_local_channel_update(NULL, &chan->scid,
update);
daemon_conn_send(daemon->master, take(msg));
}
return update; return update;
} }

4
tests/test_pay.py
View File

@@ -1746,9 +1746,7 @@ def test_pay_retry(node_factory, bitcoind, executor, chainparams):
def test_pay_routeboost(node_factory, bitcoind, compat): def test_pay_routeboost(node_factory, bitcoind, compat):
"""Make sure we can use routeboost information. """ """Make sure we can use routeboost information. """
# l1->l2->l3--private-->l4 # l1->l2->l3--private-->l4
# Note: l1 gets upset because it extracts update for private channel. l1, l2 = node_factory.line_graph(2, announce_channels=True, wait_for_announce=True)
l1, l2 = node_factory.line_graph(2, announce_channels=True, wait_for_announce=True,
opts=[{'allow_bad_gossip': True}, {}])
l3, l4, l5 = node_factory.line_graph(3, announce_channels=False, wait_for_announce=False) l3, l4, l5 = node_factory.line_graph(3, announce_channels=False, wait_for_announce=False)
# This should a "could not find a route" because that's true. # This should a "could not find a route" because that's true.