aljaz/lightning
1
0
Fork 0
mirror of https://github.com/aljazceru/lightning.git synced 2025-12-23 09:04:22 +01:00
Code Issues Packages Projects Releases Wiki Activity

txprepare: don't crash on empty args

Browse Source 
add test for empty args check
This commit is contained in:
lisa neigut
2019-12-26 21:33:41 -06:00
committed by Christian Decker
parent c2434ad4fb
commit 1763960c4a
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
contrib/pyln-client/pyln/client/lightning.py
View File

@@ -1069,7 +1069,7 @@ class LightningRpc(UnixDomainSocketRpc):
if 'destination' in kwargs or 'satoshi' in kwargs: if 'destination' in kwargs or 'satoshi' in kwargs:
return self._deprecated_txprepare(*args, **kwargs) return self._deprecated_txprepare(*args, **kwargs)
if not isinstance(args[0], list): if len(args) and not isinstance(args[0], list):
return self._deprecated_txprepare(*args, **kwargs) return self._deprecated_txprepare(*args, **kwargs)
def _txprepare(outputs, feerate=None, minconf=None, utxos=None): def _txprepare(outputs, feerate=None, minconf=None, utxos=None):

2
tests/test_wallet.py
View File

@@ -280,7 +280,7 @@ def test_txprepare(node_factory, bitcoind, chainparams):
bitcoind.generate_block(1) bitcoind.generate_block(1)
wait_for(lambda: len(l1.rpc.listfunds()['outputs']) == 10) wait_for(lambda: len(l1.rpc.listfunds()['outputs']) == 10)
prep = l1.rpc.txprepare([{addr: Millisatoshi(amount * 3 * 1000)}]) prep = l1.rpc.txprepare(outputs=[{addr: Millisatoshi(amount * 3 * 1000)}])
decode = bitcoind.rpc.decoderawtransaction(prep['unsigned_tx']) decode = bitcoind.rpc.decoderawtransaction(prep['unsigned_tx'])
assert decode['txid'] == prep['txid'] assert decode['txid'] == prep['txid']
# 4 inputs, 2 outputs (3 if we have a fee output). # 4 inputs, 2 outputs (3 if we have a fee output).