From 16fde5c79d41f75a54a3138409b5697a23e9b2f4 Mon Sep 17 00:00:00 2001 From: lisa neigut Date: Mon, 28 Oct 2019 18:31:57 -0500 Subject: [PATCH] releases: break up first git tag for verification purposes I'm not sure what went wrong, but the first RC I cut had some trouble with the tag being picked up with `git describe`, I think it was missing a 'tag message'. I'm not sure what caused this. This commit breaks up the first git tag procedure to have the releaser verify that the tag command works as intended (and sensitizes them to checking this for subsequent release cuts, if necessary) --- doc/MAKING-RELEASES.md | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/doc/MAKING-RELEASES.md b/doc/MAKING-RELEASES.md index 3db6501d9..990d15021 100644 --- a/doc/MAKING-RELEASES.md +++ b/doc/MAKING-RELEASES.md @@ -29,8 +29,11 @@ Here's a checklist for the release process. ### Releasing -rc1 -1. Merge the PR above. -2. Tag it `git pull && git tag -s vrc1 && git push --tags` +1. Merge the above PR. +2. Tag it `git pull && git tag -s vrc1`. Note that you + should get a prompt to give this tag a 'message'. Make sure you fill this in. +3. Confirm that the tag will show up for builds with `git describe` +4. Push the tag to remote `git push --tags`. 3. Update the /topic on #c-lightning on Freenode. 4. Prepare draft release notes (see devtools/credit), and share with team for editing. 5. Upgrade your personal nodes to the rc1, to help testing.