aljaz/lightning
1
0
Fork 0
mirror of https://github.com/aljazceru/lightning.git synced 2026-01-06 07:34:21 +01:00
Code Issues Packages Projects Releases Wiki Activity

commando: correctly replace the id field in responses.

Browse Source 
This was reported a while ago: now do it properly.

Fixes: #5637
Changelog-Fixed: Plugins: `commando` now responds to remote JSON calls with the correct JSON `id` field.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This commit is contained in:
Rusty Russell
2023-01-03 14:53:28 +10:30
parent b75ada7017
commit 1250806060
2 changed files with 28 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
tests/test_plugin.py
View File

@@ -2609,9 +2609,7 @@ def test_plugin_shutdown(node_factory):
def test_commando(node_factory, executor):
l1, l2 = node_factory.line_graph(2, fundchannel=False,
opts={'log-level': 'io',
# FIXME: Currently, our JSON ids in replies are wrong, hence BROKEN!
'allow_broken_log': True})
opts={'log-level': 'io'})
# Nothing works until we've issued a rune.
fut = executor.submit(l2.rpc.call, method='commando',
@@ -2706,8 +2704,7 @@ def test_commando(node_factory, executor):
def test_commando_rune(node_factory):
# FIXME: Currently, our JSON ids in replies are wrong, hence BROKEN!
l1, l2 = node_factory.get_nodes(2, opts={'allow_broken_log': True})
l1, l2 = node_factory.get_nodes(2)
# Force l1's commando secret
l1.rpc.datastore(key=['commando', 'secret'], hex='1241faef85297127c2ac9bde95421b2c51e5218498ae4901dc670c974af4284b')
@@ -2942,8 +2939,7 @@ def test_commando_rune(node_factory):
def test_commando_stress(node_factory, executor):
"""Stress test to slam commando with many large queries"""
# FIXME: Currently, our JSON ids in replies are wrong, hence BROKEN!
nodes = node_factory.get_nodes(5, opts={'allow_broken_log': True})
nodes = node_factory.get_nodes(5)
rune = nodes[0].rpc.commando_rune()['rune']
for n in nodes[1:]: