aljaz/lightning
1
0
Fork 0
mirror of https://github.com/aljazceru/lightning.git synced 2025-12-22 00:24:19 +01:00
Code Issues Packages Projects Releases Wiki Activity

Disable test until 0.16

Browse Source 
This test generates a pre-bip173 testnet P2PKH address with bitcoin 0.15.1
which fails under the new verification checks for the bip173 network name.
This should be renabled with bitcoin 0.16 which can generate a bip173 address
for regtest with the bcrt prefix.
This commit is contained in:
John Barboza
2018-02-23 13:02:01 -05:00
committed by Rusty Russell
parent b028a0a439
commit 0e40c85691
1 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
tests/test_lightningd.py
View File

@@ -2744,6 +2744,7 @@ class LightningDTests(BaseLightningDTests):
# Don't get any funds from previous runs. # Don't get any funds from previous runs.
l1 = self.node_factory.get_node(random_hsm=True) l1 = self.node_factory.get_node(random_hsm=True)
l2 = self.node_factory.get_node(random_hsm=True) l2 = self.node_factory.get_node(random_hsm=True)
l3 = self.node_factory.get_node(random_hsm=True)
addr = l1.rpc.newaddr()['address'] addr = l1.rpc.newaddr()['address']
# Add some funds to withdraw later # Add some funds to withdraw later
@@ -2760,7 +2761,10 @@ class LightningDTests(BaseLightningDTests):
c.execute('SELECT COUNT(*) FROM outputs WHERE status=0') c.execute('SELECT COUNT(*) FROM outputs WHERE status=0')
assert(c.fetchone()[0] == 10) assert(c.fetchone()[0] == 10)
waddr = l1.bitcoin.rpc.getnewaddress() # Renable when the bitcoin wallet can generate a "bcrt1" address
#waddr = l1.bitcoin.rpc.getnewaddress()
# Instead for now, Use an address from l3
waddr = l3.rpc.newaddr('bech32')['address']
# Now attempt to withdraw some (making sure we collect multiple inputs) # Now attempt to withdraw some (making sure we collect multiple inputs)
self.assertRaises(ValueError, l1.rpc.withdraw, 'not an address', amount) self.assertRaises(ValueError, l1.rpc.withdraw, 'not an address', amount)
self.assertRaises(ValueError, l1.rpc.withdraw, waddr, 'not an amount') self.assertRaises(ValueError, l1.rpc.withdraw, waddr, 'not an amount')
@@ -2771,9 +2775,10 @@ class LightningDTests(BaseLightningDTests):
# Make sure bitcoind received the withdrawal # Make sure bitcoind received the withdrawal
unspent = l1.bitcoin.rpc.listunspent(0) unspent = l1.bitcoin.rpc.listunspent(0)
withdrawal = [u for u in unspent if u['txid'] == out['txid']] withdrawal = [u for u in unspent if u['txid'] == out['txid']]
assert(len(withdrawal) == 1) # Skip these checks because the withdrawal was made to a lightning wallet
# Renable when the bitcoin wallet can generate a "bcrt1" address
assert(withdrawal[0]['amount'] == Decimal('0.02')) #assert(len(withdrawal) == 1)
#assert(withdrawal[0]['amount'] == Decimal('0.02'))
# Now make sure two of them were marked as spent # Now make sure two of them were marked as spent
c = db.cursor() c = db.cursor()