aljaz/lightning
1
0
Fork 0
mirror of https://github.com/aljazceru/lightning.git synced 2025-12-19 15:14:23 +01:00
Code Issues Packages Projects Releases Wiki Activity

openingd: don't allow reserve less than dust.

Browse Source 
This quotes from the BOLT proposal at https://github.com/lightningnetwork/lightning-rfc/pull/389

Don't try to fund channels with reserve less than dust, nor allow them
to fund channels with reserve less than dust.

Fixes: #632
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This commit is contained in:
Rusty Russell
2018-03-17 13:33:36 +10:30
committed by Christian Decker
parent f83c4ff903
commit 0c2447ed77
1 changed files with 32 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
openingd/opening.c
View File

@@ -165,12 +165,40 @@ static void check_config_bounds(struct state *state,
&state->channel_id, &state->channel_id,
"max_accepted_htlcs %u too large", "max_accepted_htlcs %u too large",
remoteconf->max_accepted_htlcs); remoteconf->max_accepted_htlcs);
/* BOLT #2:
*
* The receiving node MUST fail the channel if:
*...
* - `dust_limit_satoshis` is greater than `channel_reserve_satoshis`.
*/
if (remoteconf->dust_limit_satoshis
> remoteconf->channel_reserve_satoshis)
peer_failed(&state->cs, state->gossip_index,
&state->channel_id,
"dust_limit_satoshis %"PRIu64
" too large for channel_reserve_satoshis %"PRIu64,
remoteconf->dust_limit_satoshis,
remoteconf->channel_reserve_satoshis);
} }
/* We always set channel_reserve_satoshis to 1%, rounded up. */ /* We always set channel_reserve_satoshis to 1%, rounded up. */
static void set_reserve(u64 *reserve, u64 funding) static void set_reserve(struct state *state)
{ {
*reserve = (funding + 99) / 100; state->localconf.channel_reserve_satoshis
= (state->funding_satoshis + 99) / 100;
/* BOLT #2:
*
* The sending node:
*...
* - MUST set `channel_reserve_satoshis` greater than or equal to
* `dust_limit_satoshis`.
*/
if (state->localconf.channel_reserve_satoshis
< state->localconf.dust_limit_satoshis)
state->localconf.channel_reserve_satoshis
= state->localconf.dust_limit_satoshis;
} }
/* BOLT #2: /* BOLT #2:
@@ -221,8 +249,7 @@ static u8 *funder_channel(struct state *state,
const u8 *wscript; const u8 *wscript;
struct bitcoin_tx *funding; struct bitcoin_tx *funding;
set_reserve(&state->localconf.channel_reserve_satoshis, set_reserve(state);
state->funding_satoshis);
temporary_channel_id(&state->channel_id); temporary_channel_id(&state->channel_id);
@@ -557,8 +584,7 @@ static u8 *fundee_channel(struct state *state,
"feerate_per_kw %u above maximum %u", "feerate_per_kw %u above maximum %u",
state->feerate_per_kw, max_feerate); state->feerate_per_kw, max_feerate);
set_reserve(&state->localconf.channel_reserve_satoshis, set_reserve(state);
state->funding_satoshis);
check_config_bounds(state, state->remoteconf); check_config_bounds(state, state->remoteconf);
msg = towire_accept_channel(state, &state->channel_id, msg = towire_accept_channel(state, &state->channel_id,