aljaz/lightning
1
0
Fork 0
mirror of https://github.com/aljazceru/lightning.git synced 2026-01-06 07:34:21 +01:00
Code Issues Packages Projects Releases Wiki Activity

listtransactions: don't create a msat field called "satoshis".

Browse Source 
That's a terrible, terrible idea.  (Documentation comes in later patch
which has the schema).

Also, blockheight is a u32, so simplify.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Changelog-Deprecated: JSON-RPC: `listtransactions` `outputs` `satoshis` field (use `msat` instead).
This commit is contained in:
Rusty Russell
2021-06-16 10:31:17 +09:30
parent d8136d856b
commit 0a99b8c64c
2 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tests/test_wallet.py
View File

@@ -937,7 +937,7 @@ def test_transaction_annotations(node_factory, bitcoind):
assert(len(txs) == 1)
tx = txs[0]
output = tx['outputs'][idx]
assert(output['type'] == 'deposit' and output['satoshis'] == '1000000000msat')
assert(output['type'] == 'deposit' and output['msat'] == Millisatoshi(1000000000))
# ... and all other output should be change, and have no annotations
types = []