From 08d8de8e45f300670df11c811927bbf074a6698e Mon Sep 17 00:00:00 2001 From: niftynei Date: Tue, 19 Jul 2022 17:04:36 +0930 Subject: [PATCH] bkpr: don't try to add fees if this tx didn't touch any accts Dividing by zero causes problems. --- plugins/bkpr/recorder.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/plugins/bkpr/recorder.c b/plugins/bkpr/recorder.c index 6ffeeddfd..9754f01a8 100644 --- a/plugins/bkpr/recorder.c +++ b/plugins/bkpr/recorder.c @@ -1051,6 +1051,10 @@ char *maybe_update_onchain_fees(const tal_t *ctx, struct db *db, } } + /* Only affects external accounts, we can ignore */ + if (no_accts == 0) + goto finished; + /* If either is zero, keep waiting */ if (amount_msat_zero(withdraw_msat) || amount_msat_zero(deposit_msat)) @@ -1099,7 +1103,7 @@ char *maybe_update_onchain_fees(const tal_t *ctx, struct db *db, last_id = events[i]->acct_db_id; - /* We *never assign fees to external accounts; + /* We *never* assign fees to external accounts; * if external funds were contributed to a tx * we wouldn't record it -- fees are solely ours */ if (last_id == extern_id)