aljaz/lightning
1
0
Fork 0
mirror of https://github.com/aljazceru/lightning.git synced 2025-12-24 01:24:26 +01:00
Code Issues Packages Projects Releases Wiki Activity

features: have clear_feature_bit correctly resize bitfield

Browse Source 
There's a spec rule about only ever sending a correctly sized
feature-bits, so as a precaution we have `clear_feature_bit` correctly
resize when a bit is cleared.
This commit is contained in:
niftynei
2020-10-22 12:09:14 -05:00
committed by neil saitug
parent c7839dff76
commit 0871bf0999
2 changed files with 50 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
common/test/run-features.c
View File

@@ -179,6 +179,39 @@ static void test_feature_set_or(void)
}
}
static void test_feature_trim(void)
{
struct feature_set *f;
for (size_t i = 0; i < ARRAY_SIZE(f->bits); i++) {
f = talz(tmpctx, struct feature_set);
f->bits[i] = tal_arr(f, u8, 0);
set_feature_bit(&f->bits[i], 255);
assert(tal_bytelen(f->bits[i]) == 32);
clear_feature_bit(f->bits[i], 255);
trim_features(&f->bits[i]);
assert(tal_bytelen(f->bits[i]) == 0);
set_feature_bit(&f->bits[i], 7);
assert(tal_bytelen(f->bits[i]) == 1);
set_feature_bit(&f->bits[i], 255);
assert(tal_bytelen(f->bits[i]) == 32);
clear_feature_bit(f->bits[i], 255);
trim_features(&f->bits[i]);
assert(tal_bytelen(f->bits[i]) == 1);
clear_feature_bit(f->bits[i], 7);
trim_features(&f->bits[i]);
assert(tal_bytelen(f->bits[i]) == 0);
set_feature_bit(&f->bits[i], 8);
set_feature_bit(&f->bits[i], 10);
assert(tal_bytelen(f->bits[i]) == 2);
clear_feature_bit(f->bits[i], 10);
trim_features(&f->bits[i]);
assert(tal_bytelen(f->bits[i]) == 2);
}
}
int main(void)
{
u8 *bits;
@@ -265,6 +298,7 @@ int main(void)
test_featurebits_or();
test_feature_set_or();
test_feature_trim();
wally_cleanup(0);
tal_free(tmpctx);