aljaz/lightning
1
0
Fork 0
mirror of https://github.com/aljazceru/lightning.git synced 2025-12-23 00:54:20 +01:00
Code Issues Packages Projects Releases Wiki Activity

autoclean: Fix a null-pointer derefence when checking HTLC age

Browse Source 
The autoclean plugin would assume we have a `resolved_time` which may
not be true for oldish nodes that predate our annotations.

Changelog-None Unreleased change

Reported-by: <@devastgh>
This commit is contained in:
Christian Decker
2022-11-23 13:42:41 +01:00
committed by Rusty Russell
parent ece77840f9
commit 02f9c2df24
1 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
plugins/autoclean.c
View File

@@ -324,6 +324,14 @@ static struct command_result *listforwards_done(struct command *cmd,
continue; continue;
} }
/* Check if we have a resolved_time, before making a
* decision on it. This is possible in older nodes
* that predate our annotations for forwards.*/
if (json_get_member(buf, t, "resolved_time") == NULL) {
cinfo->num_uncleaned++;
continue;
}
time = *json_get_member(buf, t, "resolved_time"); time = *json_get_member(buf, t, "resolved_time");
/* This is a float, so truncate at '.' */ /* This is a float, so truncate at '.' */
for (int off = time.start; off < time.end; off++) { for (int off = time.start; off < time.end; off++) {