From 4981fdd35b8d38121d366d48415806841dd5a38e Mon Sep 17 00:00:00 2001 From: MTG2000 Date: Mon, 3 Oct 2022 18:00:49 +0300 Subject: [PATCH] update: QA improvements & fixes --- .../ProfilePage/StoriesCard/StoriesCard.tsx | 2 +- .../Components/AboutCard/AboutCard.tsx | 13 ++++++++++-- .../CapabilitiesCard/CapabilitiesCard.tsx | 2 +- .../Components/MakersCard/MakersCard.tsx | 2 +- .../SimilarProjectsCard.tsx | 2 +- .../ProjectDetailsCard/ProjectDetailsCard.tsx | 20 ++++++++++--------- .../pages/ProjectPage/ProjectPage.tsx | 15 +++++++++++--- 7 files changed, 38 insertions(+), 18 deletions(-) diff --git a/src/features/Profiles/pages/ProfilePage/StoriesCard/StoriesCard.tsx b/src/features/Profiles/pages/ProfilePage/StoriesCard/StoriesCard.tsx index c292808..d7c114a 100644 --- a/src/features/Profiles/pages/ProfilePage/StoriesCard/StoriesCard.tsx +++ b/src/features/Profiles/pages/ProfilePage/StoriesCard/StoriesCard.tsx @@ -52,7 +52,7 @@ export default function StoriesCard({ stories, isOwner, onlyMd }: Props) { } {stories.length === 0 &&
-

+

😐 No Stories Added Yet

{/*

diff --git a/src/features/Projects/pages/ProjectPage/Components/AboutCard/AboutCard.tsx b/src/features/Projects/pages/ProjectPage/Components/AboutCard/AboutCard.tsx index 75727a9..787bc0d 100644 --- a/src/features/Projects/pages/ProjectPage/Components/AboutCard/AboutCard.tsx +++ b/src/features/Projects/pages/ProjectPage/Components/AboutCard/AboutCard.tsx @@ -10,6 +10,7 @@ import { setVoteAmount } from 'src/redux/features/vote.slice' import { numberFormatter } from 'src/utils/helperFunctions' import { useAppDispatch } from 'src/utils/hooks' import { createRoute } from 'src/utils/routing' +import LinksCard from '../LinksCard/LinksCard' interface Props { project: Pick } @@ -52,7 +59,7 @@ export default function AboutCard({ project }: Props) { return ( {/* Cover Image */} -

+
{project.launch_status === ProjectLaunchStatusEnum.Launched && `🚀 Launched`} @@ -82,7 +89,9 @@ export default function AboutCard({ project }: Props) { { {numberFormatter(project.votes_count)}}
- +
+ +
{/* About */}
diff --git a/src/features/Projects/pages/ProjectPage/Components/CapabilitiesCard/CapabilitiesCard.tsx b/src/features/Projects/pages/ProjectPage/Components/CapabilitiesCard/CapabilitiesCard.tsx index c8a937a..7c5a6c5 100644 --- a/src/features/Projects/pages/ProjectPage/Components/CapabilitiesCard/CapabilitiesCard.tsx +++ b/src/features/Projects/pages/ProjectPage/Components/CapabilitiesCard/CapabilitiesCard.tsx @@ -17,7 +17,7 @@ export default function CapabilitiesCard({ capabilities }: Props) { {capabilities.length === 0 && <>

No capabilities added

} -
+
{capabilities.map(cap => {cap.icon} {cap.title})}
diff --git a/src/features/Projects/pages/ProjectPage/Components/MakersCard/MakersCard.tsx b/src/features/Projects/pages/ProjectPage/Components/MakersCard/MakersCard.tsx index c57c8cd..7a9e2b5 100644 --- a/src/features/Projects/pages/ProjectPage/Components/MakersCard/MakersCard.tsx +++ b/src/features/Projects/pages/ProjectPage/Components/MakersCard/MakersCard.tsx @@ -40,7 +40,7 @@ export default function MakersCard({ members, recruit_roles }: Props) { {recruit_roles.length === 0 && <>

No open roles for now

} -
+
{recruit_roles.map(role => {role.icon} {role.title})}
diff --git a/src/features/Projects/pages/ProjectPage/Components/SimilarProjectsCard/SimilarProjectsCard.tsx b/src/features/Projects/pages/ProjectPage/Components/SimilarProjectsCard/SimilarProjectsCard.tsx index 59c0706..3f2ddd9 100644 --- a/src/features/Projects/pages/ProjectPage/Components/SimilarProjectsCard/SimilarProjectsCard.tsx +++ b/src/features/Projects/pages/ProjectPage/Components/SimilarProjectsCard/SimilarProjectsCard.tsx @@ -22,7 +22,7 @@ export default function SimilarProjectsCard({ id }: Props) {

🚀 Similar projects

    {query.data?.similarProjects.map(project => { - return + return
  • diff --git a/src/features/Projects/pages/ProjectPage/ProjectDetailsCard/ProjectDetailsCard.tsx b/src/features/Projects/pages/ProjectPage/ProjectDetailsCard/ProjectDetailsCard.tsx index 202b1f2..6963b36 100644 --- a/src/features/Projects/pages/ProjectPage/ProjectDetailsCard/ProjectDetailsCard.tsx +++ b/src/features/Projects/pages/ProjectPage/ProjectDetailsCard/ProjectDetailsCard.tsx @@ -120,14 +120,16 @@ export default function ProjectDetailsCard({ direction, projectId, ...props }: P {/* Cover Image */}
    -
    - {project.launch_status === ProjectLaunchStatusEnum.Launched && `🚀 Launched`} - {project.launch_status === ProjectLaunchStatusEnum.Wip && `🔧 WIP`} -
    -
    - {project.permissions.includes(ProjectPermissionEnum.UpdateInfo) && - props.onClose?.()} to={createRoute({ type: "edit-project", id: project.id })}>} - +
    +
    + {project.launch_status === ProjectLaunchStatusEnum.Launched && `🚀 Launched`} + {project.launch_status === ProjectLaunchStatusEnum.Wip && `🔧 WIP`} +
    +
    + {project.permissions.includes(ProjectPermissionEnum.UpdateInfo) && + props.onClose?.()} to={createRoute({ type: "edit-project", id: project.id })}>} + +
    @@ -248,7 +250,7 @@ export default function ProjectDetailsCard({ direction, projectId, ...props }: P
    } - + {/*

    Are you the creator of this project

    diff --git a/src/features/Projects/pages/ProjectPage/ProjectPage.tsx b/src/features/Projects/pages/ProjectPage/ProjectPage.tsx index a0f8045..77a9033 100644 --- a/src/features/Projects/pages/ProjectPage/ProjectPage.tsx +++ b/src/features/Projects/pages/ProjectPage/ProjectPage.tsx @@ -1,7 +1,7 @@ import { useParams } from "react-router-dom" import LoadingPage from "src/Components/LoadingPage/LoadingPage" import NotFoundPage from "src/features/Shared/pages/NotFoundPage/NotFoundPage" -import { useProjectDetailsQuery } from "src/graphql" +import { ProjectLaunchStatusEnum, useProjectDetailsQuery } from "src/graphql" import { Helmet } from 'react-helmet' import { useAppDispatch, useMediaQuery } from 'src/utils/hooks'; import styles from './styles.module.scss' @@ -60,6 +60,16 @@ export default function ProjectPage() { } +
    + +
    + {project.launch_status === ProjectLaunchStatusEnum.Launched && `🚀 Launched`} + {project.launch_status === ProjectLaunchStatusEnum.Wip && `🔧 WIP`} +
    +
    + +
    +
    -

    - +