mirror of
https://github.com/aljazceru/kata-containers.git
synced 2026-01-22 07:44:25 +01:00
c91556aa41
When shimv2 was killed by accident, containerd would try to launch a new shimv2 binarry to cleanup the container. In order to avoid race condition, the cleanup should be done serialized in a sandbox. Thus adding a new api to do this by locking the sandbox. Fixes:#1832 Signed-off-by: lifupan <lifupan@gmail.com>
53 lines
1.1 KiB
Go
53 lines
1.1 KiB
Go
// Copyright (c) 2018 HyperHQ Inc.
|
|
//
|
|
// SPDX-License-Identifier: Apache-2.0
|
|
//
|
|
|
|
package containerdshim
|
|
|
|
import (
|
|
"context"
|
|
"path"
|
|
|
|
"github.com/containerd/containerd/mount"
|
|
"github.com/kata-containers/runtime/pkg/katautils"
|
|
"github.com/kata-containers/runtime/virtcontainers/types"
|
|
|
|
"github.com/sirupsen/logrus"
|
|
)
|
|
|
|
func deleteContainer(ctx context.Context, s *service, c *container) error {
|
|
if !c.cType.IsSandbox() {
|
|
status, err := s.sandbox.StatusContainer(c.id)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
if status.State.State != types.StateStopped {
|
|
_, err = s.sandbox.StopContainer(c.id, false)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
}
|
|
|
|
if _, err = s.sandbox.DeleteContainer(c.id); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
|
|
// Run post-stop OCI hooks.
|
|
if err := katautils.PostStopHooks(ctx, *c.spec, s.sandbox.ID(), c.bundle); err != nil {
|
|
return err
|
|
}
|
|
|
|
if s.mount {
|
|
rootfs := path.Join(c.bundle, "rootfs")
|
|
if err := mount.UnmountAll(rootfs, 0); err != nil {
|
|
logrus.WithError(err).Warn("failed to cleanup rootfs mount")
|
|
}
|
|
}
|
|
|
|
delete(s.containers, c.id)
|
|
|
|
return nil
|
|
}
|