mirror of
https://github.com/aljazceru/kata-containers.git
synced 2026-01-07 08:24:23 +01:00
Currently we sometimes pass it as a pointer and other times not. As a result, the view of sandbox across virtcontainers may not be the same and it costs extra memory copy each time we pass it by value. Fix it by ensuring sandbox is always passed by pointers. Fixes: #262 Signed-off-by: Peng Tao <bergwolf@gmail.com>
93 lines
2.1 KiB
Go
93 lines
2.1 KiB
Go
// Copyright (c) 2018 HyperHQ Inc.
|
|
//
|
|
// SPDX-License-Identifier: Apache-2.0
|
|
//
|
|
|
|
package virtcontainers
|
|
|
|
import (
|
|
"bufio"
|
|
"fmt"
|
|
"io"
|
|
"net"
|
|
|
|
"github.com/sirupsen/logrus"
|
|
)
|
|
|
|
// This is a kata builtin proxy implementation of the proxy interface. Kata proxy
|
|
// functionality is implemented inside the virtcontainers library.
|
|
type kataBuiltInProxy struct {
|
|
sandboxID string
|
|
conn net.Conn
|
|
}
|
|
|
|
// start is the proxy start implementation for kata builtin proxy.
|
|
// It starts the console watcher for the guest.
|
|
// It returns agentURL to let agent connect directly.
|
|
func (p *kataBuiltInProxy) start(sandbox *Sandbox, params proxyParams) (int, string, error) {
|
|
if p.conn != nil {
|
|
return -1, "", fmt.Errorf("kata builtin proxy running for sandbox %s", p.sandboxID)
|
|
}
|
|
|
|
p.sandboxID = sandbox.id
|
|
console := sandbox.hypervisor.getSandboxConsole(sandbox.id)
|
|
err := p.watchConsole(consoleProtoUnix, console, params.logger)
|
|
if err != nil {
|
|
return -1, "", err
|
|
}
|
|
|
|
return -1, params.agentURL, nil
|
|
}
|
|
|
|
// stop is the proxy stop implementation for kata builtin proxy.
|
|
func (p *kataBuiltInProxy) stop(sandbox *Sandbox, pid int) error {
|
|
if p.conn != nil {
|
|
p.conn.Close()
|
|
p.conn = nil
|
|
p.sandboxID = ""
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func (p *kataBuiltInProxy) watchConsole(proto, console string, logger *logrus.Entry) (err error) {
|
|
var (
|
|
scanner *bufio.Scanner
|
|
conn net.Conn
|
|
)
|
|
|
|
switch proto {
|
|
case consoleProtoUnix:
|
|
conn, err = net.Dial("unix", console)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
// TODO: add pty console support for kvmtools
|
|
case consoleProtoPty:
|
|
fallthrough
|
|
default:
|
|
return fmt.Errorf("unknown console proto %s", proto)
|
|
}
|
|
|
|
p.conn = conn
|
|
|
|
go func() {
|
|
scanner = bufio.NewScanner(conn)
|
|
for scanner.Scan() {
|
|
fmt.Printf("[SB-%s] vmconsole: %s\n", p.sandboxID, scanner.Text())
|
|
}
|
|
|
|
if err := scanner.Err(); err != nil {
|
|
if err == io.EOF {
|
|
logger.Info("console watcher quits")
|
|
} else {
|
|
logger.WithError(err).WithFields(logrus.Fields{
|
|
"console-protocol": proto,
|
|
"console-socket": console,
|
|
}).Error("Failed to read agent logs")
|
|
}
|
|
}
|
|
}()
|
|
|
|
return nil
|
|
}
|