mirror of
https://github.com/aljazceru/kata-containers.git
synced 2026-01-03 06:24:21 +01:00
8551853cfe
In TestHandleHugepages it will do a mount operation with different pagesizes, but some systems only support 2M pagesize, test for a 1g pagesize will fail. This commit try to fix by only mount pagesizes under `/sys/kernel/mm/hugepages`, which are supported to mount by the OS. Fixes: #6029 Signed-off-by: Bin Liu <bin@hyper.sh>
74 lines
1.8 KiB
Go
74 lines
1.8 KiB
Go
// Copyright (c) 2018 Intel Corporation
|
|
//
|
|
// SPDX-License-Identifier: Apache-2.0
|
|
//
|
|
|
|
package virtcontainers
|
|
|
|
import (
|
|
"fmt"
|
|
"os"
|
|
"path"
|
|
"strings"
|
|
"syscall"
|
|
"testing"
|
|
|
|
specs "github.com/opencontainers/runtime-spec/specs-go"
|
|
"github.com/stretchr/testify/assert"
|
|
|
|
"code.cloudfoundry.org/bytefmt"
|
|
)
|
|
|
|
func TestHandleHugepages(t *testing.T) {
|
|
if os.Getuid() != 0 {
|
|
t.Skip("Test disabled as requires root user")
|
|
}
|
|
|
|
assert := assert.New(t)
|
|
|
|
dir := t.TempDir()
|
|
|
|
k := kataAgent{}
|
|
var formattedSizes []string
|
|
var mounts []specs.Mount
|
|
var hugepageLimits []specs.LinuxHugepageLimit
|
|
|
|
// Hugepage sizes must be set at boot time and cannot be created ad hoc.
|
|
// Use any that are present.
|
|
dirs, err := os.ReadDir(sysHugepagesDir)
|
|
assert.Nil(err)
|
|
for _, dir := range dirs {
|
|
formattedSizes = append(formattedSizes, strings.TrimPrefix(dir.Name(), "hugepages-"))
|
|
}
|
|
|
|
for _, formattedSize := range formattedSizes {
|
|
bytes, err := bytefmt.ToBytes(formattedSize)
|
|
assert.Nil(err)
|
|
hugepageLimits = append(hugepageLimits, specs.LinuxHugepageLimit{
|
|
Pagesize: formattedSize,
|
|
Limit: 1_000_000 * bytes,
|
|
})
|
|
|
|
target := path.Join(dir, fmt.Sprintf("hugepages-%s", formattedSize))
|
|
err = os.MkdirAll(target, 0777)
|
|
assert.NoError(err, "Unable to create dir %s", target)
|
|
|
|
err = syscall.Mount("nodev", target, "hugetlbfs", uintptr(0), fmt.Sprintf("pagesize=%s", formattedSize))
|
|
assert.NoError(err, "Unable to mount %s", target)
|
|
|
|
defer syscall.Unmount(target, 0)
|
|
defer os.RemoveAll(target)
|
|
mount := specs.Mount{
|
|
Type: KataLocalDevType,
|
|
Source: target,
|
|
}
|
|
mounts = append(mounts, mount)
|
|
}
|
|
|
|
hugepages, err := k.handleHugepages(mounts, hugepageLimits)
|
|
|
|
assert.NoError(err, "Unable to handle hugepages %v", hugepageLimits)
|
|
assert.NotNil(hugepages)
|
|
assert.Equal(len(hugepages), len(formattedSizes))
|
|
}
|