mirror of
https://github.com/aljazceru/kata-containers.git
synced 2025-12-23 09:14:27 +01:00
3a1bbd0271
Add initial support for opentracing by using the `jaeger` package.
Since opentracing uses the `context` package, add a `context.Context`
as the first parameter to all the functions that we might want to
trace. Trace "spans" (trace points) are then added by extracting the
trace details from the specified context parameter.
Notes:
- Although the tracer is created in `main()`, the "root span"
(aka the first trace point) is not added until `beforeSubcommands()`.
This is by design and is a compromise: by delaying the creation of the
root span, the spans become much more readable since using the web-based
JaegerUI, you will see traces like this:
```
kata-runtime: kata-runtime create
------------ -------------------
^ ^
| |
Trace name First span name
(which clearly shows the CLI command that was run)
```
Creating the span earlier means it is necessary to expand 'n' spans in
the UI before you get to see the name of the CLI command that was run.
In adding support, this became very tedious, hence my design decision to
defer the creation of the root span until after signal handling has been
setup and after CLI options have been parsed, but still very early in
the code path.
- At this stage, the tracing stops at the `virtcontainers` call
boundary.
- Tracing is "always on" as there doesn't appear to be a way to toggle
it. However, its resolves to a "nop" unless the tracer can talk to a
jaeger agent.
Note that this commit required a bit of rework to `beforeSubcommands()`
to reduce the cyclomatic complexity.
Fixes #557.
Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
54 lines
1.7 KiB
Go
54 lines
1.7 KiB
Go
// Copyright (c) 2017 Uber Technologies, Inc.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package jaeger
|
|
|
|
import "log"
|
|
|
|
// NB This will be deprecated in 3.0.0, please use jaeger-client-go/log/logger instead.
|
|
|
|
// Logger provides an abstract interface for logging from Reporters.
|
|
// Applications can provide their own implementation of this interface to adapt
|
|
// reporters logging to whatever logging library they prefer (stdlib log,
|
|
// logrus, go-logging, etc).
|
|
type Logger interface {
|
|
// Error logs a message at error priority
|
|
Error(msg string)
|
|
|
|
// Infof logs a message at info priority
|
|
Infof(msg string, args ...interface{})
|
|
}
|
|
|
|
// StdLogger is implementation of the Logger interface that delegates to default `log` package
|
|
var StdLogger = &stdLogger{}
|
|
|
|
type stdLogger struct{}
|
|
|
|
func (l *stdLogger) Error(msg string) {
|
|
log.Printf("ERROR: %s", msg)
|
|
}
|
|
|
|
// Infof logs a message at info priority
|
|
func (l *stdLogger) Infof(msg string, args ...interface{}) {
|
|
log.Printf(msg, args...)
|
|
}
|
|
|
|
// NullLogger is implementation of the Logger interface that delegates to default `log` package
|
|
var NullLogger = &nullLogger{}
|
|
|
|
type nullLogger struct{}
|
|
|
|
func (l *nullLogger) Error(msg string) {}
|
|
func (l *nullLogger) Infof(msg string, args ...interface{}) {}
|